restrict_manage_posts in wp-media-list-table.php missing 2nd param

[wpsmith]

restrict_manage_posts in wp-media-list-table.php missing 2nd param that is available and present within wp-admin/includes/class-wp-posts-list-table.php

[wpsmith]

Adds second param to action.

[helen]

Seems like it makes sense to match wp-admin/includes/class-wp-posts-list-table.php.

[flixos90]

The $which parameter was added to the restrict_manage_posts action in 37422, so I assume the filter occurrence in the media list table was overlooked. The existing patch looks good to fix that.

Regarding the ticket type, I agree with @wpsmith that this is a bug, since it should be expected that a hook has parameter parity wherever it is executed. Since it's not a bug against trunk, let's move it to 4.8.

[flixos90]

Having a second look, it might not be as simple: The media list table uses the value "bar" for its $which usage while regular post list tables use "top" or "bottom". I think the patch should also address this in the docs for the $which parameter in the post list table class:

The location of the extra table nav markup: 'top' or 'bottom' for regular post types, or 'bar' for attachments.

[wpsmith]

Updated the patch to trunk & added documentation.

[SergeyBiryukov]

In 39917:

List Tables: Pass the $which parameter to restrict_manage_posts filter instance in WP_Media_List_Table, missed in [37422].

Props wpsmith.
Fixes #38772.