Twenty Seventeen: Specific fonts for Thai font

[Imnok]

Hi there, Twenty Seventeen theme is very cool! I really love it.

To make it better with Thai font, I think we can add specific fonts as well.
Here is my suggestion.

/* Typography for Thai Font */

html[lang="th"] h1,
html[lang="th"] h2,
html[lang="th"] h3,
html[lang="th"] h4,
html[lang="th"] h5,
html[lang="th"] h6 {
line-height: 1.65;
font-family: "Sukhumvit Set", "Helvetica Neue", helvetica, arial, sans-serif;
}

html[lang="th"] body,
html[lang="th"] button,
html[lang="th"] input,
html[lang="th"] select,
html[lang="th"] textarea {
line-height: 1.8;
font-family: "Helvetica Neue", helvetica, arial, sans-serif;
} 

[Presskopp]

corresponding patch

[netweb]

Patch 38937.1.diff​ correctly capitalises Helvetica and Arial

[davidakennedy]

Hey @Imnok! Welcome, and thank you for the thoughtful suggestion. Why would a specific font stack make things better in this case?

I'll leave it to @melchoyce, who led the language-specific CSS work, to make the call here. I'm okay with trying to get this in this release, if it dramatically improves the experience.

[melchoyce]

Is Sukhumvit Set a font installed by default on Windows? (I don't see it on Mac.) Wondering because we're only including system fonts for non-latin languages, rather than including extra web fonts that people would either need to download, or we'd need to serve alongside the Franklin Libre in the theme.

[Imnok]

Thanks! @davidakennedy. Because the Sukhumvit font I recommend is creating for Thai alphabet, so it's properly rendered, beautiful, modern and easy to read as well.

[Imnok]

Hi @melchoyce. No, it isn't. "Sukhumvit Set" font is a system font comes with OS X (Mac) - here is a reference ​https://en.wikipedia.org/wiki/List_of_typefaces_included_with_macOS#New_fonts_added_with_OS_X_10.10_Yosemite

[melchoyce]

"Sukhumvit Set" font is a system font comes with OS X (Mac)

Sorry, you're right, I'm seeing it on my font list now. As far as I can tell, it looks very nice. I think it would be a good enhancement.

It looks like 38937.1.diff​ is missing Sukhumvit Set in the second font declaration — I'm seeing it applied to headers, but not body text. I'll upload another patch.

[Imnok]

That's perfect! Thank you @melchoyce.

[Presskopp]

Attached a gif showing Windows 7 and font "Leelawadee", which seems to be the default system font in Windows 7 for Thai.

[davidakennedy]

@Imnok Thanks for the explanation! What do you think about Leelawadee (Win7) and Leelawadee UI (Win8)? We probably should have a nice font for the Windows OS.

[Imnok]

Thanks @Presskopp for suggestion!

I'd asked people around. Between 3 types of system fonts on Windows OS (Leelawadee, Arial and San-serif), it seems we prefer "Arial" and "San-serif" font. Furthermore, Leelawadee font still has a small letter-spacing on small sizes which it's hard to read on Thai characters.

[davidakennedy]

@melchoyce What are your thoughts on the feedback from @Imnok in ticket:38937#comment:14?

[melchoyce]

Replying to davidakennedy:

@melchoyce What are your thoughts on the feedback from @Imnok in ticket:38937#comment:14?

Let's add Sukhumvit Set but leave out Leelawadee.

[davidakennedy]

Thanks @Imnok and @melchoyce!

I think we should get this in for 4.7 because it's a visual change, and better to do that now, rather than later after users make child themes, customizations, etc. based off the theme.

38937.2.diff​ looks good to go to me.

[davidakennedy]

In 39482:

Twenty Seventeen: Add specific font stack for Thai language

Improves legability and design for users viewing the theme with Thai language.

Props imnok, netweb, melchoyce.

Fixes #38937.

[helen]

In 39484:

Twenty Seventeen: Add specific font stack for Thai language

Improves legability and design for users viewing the theme with Thai language.

Props imnok, netweb, melchoyce.

Fixes #38937 for the 4.7 branch.