Customize Menus: clicking outside of the available menu items panel does not close the panel

[celloexpressions]

When the available menu items panel is open, clicking anywhere outside of the panel except for on the menu-item-delete buttons should (and used to) close the panel. In particular, clicking on the preview and clicking on an added menu item to expand its options currently do not close the available menu items panel, but clicking elsewhere in the customize pane works.

Verified that this behavior exists in 4.6.1, so it was a regression some time before 4.7.

[rockwell15]

Added pointer-events none to preview iframe when the available menu items panel is open. Then closes the panel on #customize-preview & .menu-item-handle click

[westonruter]

@celloexpressions does this get your 👍?

[celloexpressions]

38953.2.diff​ looks good and works in my testing. Still not sure when/how this broke.

[westonruter]

Just checked and it's been this way since at least 4.5.

[westonruter]

In 39548:

Customize: Collapse available nav menu items panel when clicking outside over preview or over existing items.

Props rockwell15.
Fixes #38953.

[celloexpressions]

This change broke the bulk-delete functionality. The available menu items panel can't be closed if the click is on the item-delete button within the menu item handle.

Again, the specific functionality that this ticket looks to restore previously worked, and I specifically remember adding the check for the delete button too. Not sure what happened to it.

[celloexpressions]

Since this was committed to trunk previously, two things are now required:

• Amend the trunk fix to not close the panel when the delete buttons are activated. (good-first-bug, needs a patch)
• Back-port both commits to the 4.7 branch.

[maguiar]

Fixes menu delete button and prevents available menu items from closing when removing an item

[adamsilverstein]

@westonruter

I tested 38953.diff​ and it works as expected --

Before the patch, every time i click the red X to remove a menu item, the side panel closes:

After the patch I can remove multiple items and the side panel stays open:

This patch also fixes the delete menu link not working issue:

Before (delete link doesn't work):

After - the menu is properly deleted:

[westonruter]

In 40396:

Customize: Fix behavior of clicking Delete Menu link and keep available nav menu items panel open when doing bulk deletion.

Props maguiar, adamsilverstein for testing.
Amends [39548].
Fixes #38953.

[westonruter]

Re-opening for consideration in 4.7.4

[swissspidy]

In 40401:

Customize: Fix behavior of clicking Delete Menu link and keep available nav menu items panel open when doing bulk deletion.

Props maguiar, adamsilverstein for testing.
Amends [39548].
Fixes #38953.

Merges [40396] to the 4.7 branch.