REST API: Site URL setting should not be present on multisite installations

[johnbillion]

In register_initial_settings(), the siteurl setting is registered and made available to the REST API. On a multisite installation, this setting is not configurable from the General Settings screen, but due to the above it is configurable from the REST API.

This setting should not be present (and not be available to the REST API) on a multisite installation.

[joehoyle]

Makes sense to me, as all Settings are configurable, we should remove this from the endpoint in the case of multisite. If clients want to get information about the site, (such as url) that should be retrieved form the API index, or other places. For posterity, the settings endpoint is to change configurable things, not just to provide information about the site.

[peterwilsoncc]

Inelegant with is_multisite() checks when registering the setting.

[pento]

In the tests in 39005.diff​, I'd just unset the 'url' item, rather than repeating the array.

I'm fine with the conditional to fix the bug.

[rachelbaker]

@peterwilsoncc @pento I don't think we should register the setting at all in multisite. I am sitting next to @johnbillion and he confirmed this.

[peterwilsoncc]

In 39005.2.diff​:

• unit tests use an array_diff to remove url
• option not registered in multisite

[nacin]

Looks good.

[pento]

In 39468:

REST API: Site URL setting should not be present on multisite installations.

The siteurl setting is registered and made available to the REST API. On a multisite installation, this setting is not configurable from the General Settings screen, but due to the above it is configurable from the REST API.

Props peterwilsoncc.
Fixes #39005.

[pento]

In 39469:

REST API: Site URL setting should not be present on multisite installations.

The siteurl setting is registered and made available to the REST API. On a multisite installation, this setting is not configurable from the General Settings screen, but due to the above it is configurable from the REST API.

Merge of [39468] to the 4.7 branch.

Props peterwilsoncc.
Fixes #39005.

[jnylen0]

In 40077:

REST API: Skip generating the client test fixtures in multisite mode.

There are a couple of changes to the generated API schemas between single-site and multisite mode - for example, the url and email settings are not present in the settings endpoint (see #39005).

To avoid unexpected changes to the wp-api-generated.js fixture file, skip generating the client test fixtures when running the test suite in multisite mode.

See #39264.