Opened 8 years ago
Closed 8 years ago
#39009 closed defect (bug) (fixed)
Customizer: the preview UI language should be the user language
Reported by: | afercia | Owned by: | westonruter |
---|---|---|---|
Milestone: | 4.7.1 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Customize | Keywords: | has-screenshots has-patch fixed-major commit |
Focuses: | Cc: |
Description
In WordPress 4.7 there are two languages (the site language and the user language) and any controls, text, messages, etc., that are part of the UI should be displayed in the user language, i.e. the one users choose for the admin interface.
By the way, the Customizer preview UI uses the site language. See the screenshots below, taken using these settings:
User language: Spanish
Site language: Deutsch
For example, the edit buttons title and aria label attributes should be in Spanish, as well as the "Shift Click" tooltip:
Attachments (1)
Change History (10)
#2
@
8 years ago
- Keywords has-patch added
39009.patch makes use of switch_to_locale()
and get_user_locale()
.
This ticket was mentioned in Slack in #core by westonruter. View the logs.
8 years ago
#5
@
8 years ago
- Owner set to westonruter
- Resolution set to fixed
- Status changed from new to closed
In 39545:
#6
@
8 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Re-opening for 4.7.1.
If the customize preview is running in the wrong language, the scope of the problems could be much larger than edit shortcut aria labels. There may be additional challenges here, though, because the theme is presumably using the site language. There needs to be a way to detect "admin" strings that are running in the theme/frontend context.