WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#39226 closed defect (bug) (invalid)

Twenty Fourteen: Template Edit link broken in the Page Attributes meta box

Reported by: afercia Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots
Focuses: accessibility Cc:

Description

Twenty Fourteen makes use of the page_attributes_meta_box_template filter to add an "Edit" link in the Page Attributes meta box:

https://cldup.com/-KuXe89u5I.png

This link works just for the default template page.php but since the other two page template files (contributor and full-width) are placed in a sub-directory, the related link is broken and all you get is an empty page with "that file cannot be edited" message:

https://cldup.com/WCvctYum03.png

Example working link in the Theme editor:
?file=page-templates%2Fcontributors.php&theme=twentyfourteen

broken link in the meta box:
?theme=twentyfourteen&file=contributors.php

Accessibility note: the "Edit" link text should be preferably expanded with an aria-label attribute to make sense even when read out of context.

Change History (3)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 years ago

#2 @davidakennedy
3 years ago

Hey @afercia!

Thanks for the report!

I may be missing this somewhere, so forgive me. I don't see that edit link anywhere in Twenty Fourteen on pages in the Admin, nor do I see the use of the page_attributes_meta_box_template filter. What am I missing? Are you sure this is a Twenty Fourteen issue?

#3 @afercia
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

@davidakennedy ah! Sorry, you're totally right. I still had in Twenty Fourteen a small snippet I used to test #38790 that added that "Edit link" using that filter. Sorry for wasting your time, going to close this as totally invalid report :)

Note: See TracTickets for help on using tickets.