Opened 8 years ago
Closed 7 years ago
#39241 closed defect (bug) (fixed)
Add more unit tests for the custom header feature
Reported by: | bradyvercher | Owned by: | obenland |
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Themes | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
The custom header functionality is largely untested. I introduced some tests in #38639, but they got overlooked while focusing on getting 4.7 out the door, so I'd like to reintroduce them for inclusion.
Attachments (1)
Change History (8)
#2
@
8 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 4.8
- Owner set to joemcgill
- Status changed from new to accepted
- Version set to 4.7
Thanks for following up on these @bradyvercher. The tests look good and are passing here.
This ticket was mentioned in Slack in #core by flixos90. View the logs.
7 years ago
This ticket was mentioned in Slack in #core by obenland. View the logs.
7 years ago
Note: See
TracTickets for help on using
tickets.
39241.diff contains tests introduced in #38639 and they've at least had a cursory review here.
It doesn't look like the patch keeps binary files, so the video file will need to be downloaded from this repo and saved to
tests/phpunit/data/images/video.mp4
to make the tests pass -- I wasn't sure if a new directory should be created for videos instead. According to the license, that file should be public domain: