Opened 8 years ago
Last modified 3 years ago
#39593 new defect (bug)
Improve DocBlocks in class-automatic-upgrader-skin.php
Reported by: | carl-alberto | Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
Missing DocBlock Description and wrong @param formatting in:
wp-admin/includes/class-automatic-upgrader-skin.php
public function feedback( $data )
Attachments (5)
Change History (19)
#1
@
8 years ago
- Keywords needs-refresh added
- Summary changed from Improve DocBlock for function feedback($data) in class-automatic-upgrader-skin.php to Improve DocBlocks in class-automatic-upgrader-skin.php
#2
@
8 years ago
- Keywords has-patch added
Hi Soean,
Thanks for the advice. sent another diff file to include the DocBlock improvement of:
$messages
get_upgrade_messages()
header()
footer()
Thanks!
#7
@
8 years ago
The other WP_Upgrader_Skin
classes also have incomplete DocBlocks:
WP_Upgrader_Skin
Bulk_Plugin_Upgrader_Skin
Bulk_Theme_Upgrader_Skin
Bulk_Upgrader_Skin
Language_Pack_Upgrader_Skin
Plugin_Installer_Skin
Plugin_Upgrader_Skin
Theme_Installer_Skin
Theme_Upgrader_Skin
#8
follow-up:
↓ 9
@
8 years ago
Hi @Soean,
Do we tackle all the patches thru this ticket or separate tickets per file that don't have proper DocBlocks?
Thanks!
#9
in reply to:
↑ 8
@
8 years ago
Replying to carl-alberto:
Do we tackle all the patches thru this ticket or separate tickets per file that don't have proper DocBlocks?
Let's create a separate ticket per file.
Hey Carl,
thanks for the patch. As I looked into the
Automatic_Upgrader_Skin
class, I saw that the$messages
property as well as the methodsget_upgrade_messages()
,header()
andfooter()
also needs doc improvements. They should also handled by this ticket.