WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 5 years ago

#39633 closed defect (bug) (fixed)

No HiDPI version for avatar in post locked modal

Reported by: ocean90's profile ocean90 Owned by: audrasjb's profile audrasjb
Milestone: 5.5 Priority: normal
Severity: normal Version: 4.2
Component: Posts, Post Types Keywords: has-patch has-screenshots
Focuses: ui, javascript, administration Cc:

Description

The image tag is generated in JavaScript, see https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/post.js?rev=38893&marks=203#L202, without a srcset attribute.

wp_refresh_post_lock() should probably return both versions. Also, consider switching to get_avatar_url().

Related: #22329

Attachments (4)

39633.patch​ (1.7 KB) - added by wpdesk 8 years ago.
39633.1.diff​ (2.4 KB) - added by audrasjb 5 years ago.
Posts, Posts Types: Provide HiDPI version to post locked avatar image
Capture d’écran 2020-06-18 à 23.35.52.png​ (89.7 KB) - added by audrasjb 5 years ago.
Posts, Posts Types: Provide HiDPI version to post locked avatar image
39633.2.diff​ (2.9 KB) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (13)

@wpdesk
8 years ago

#1 @wpdesk
8 years ago

  • Keywords has-patch added; needs-patch removed

#2 @DrewAPicture
8 years ago

  • Owner set to wpdesk
  • Status changed from new to assigned

Assigning ownership to mark the good-first-bug as "claimed".

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs.
5 years ago

#4 @SergeyBiryukov
5 years ago

  • Milestone changed from Future Release to 5.4

#5 @audrasjb
5 years ago

  • Milestone changed from 5.4 to 5.5

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to the next milestone. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
5 years ago

#7 @davidbaumwald
5 years ago

  • Keywords needs-refresh added

Latest patch no longer applies cleanly. Marking for a refresh.

@audrasjb
5 years ago

Posts, Posts Types: Provide HiDPI version to post locked avatar image

@audrasjb
5 years ago

Posts, Posts Types: Provide HiDPI version to post locked avatar image

#8 @audrasjb
5 years ago

  • Keywords has-screenshots added; good-first-bug needs-refresh removed
  • Owner changed from wpdesk to audrasjb

Previous patch didn't apply anymore and was incomplete.

39633.1.diff is a new patch for this issue, and seems to work well in my testing (see above screenshot).

@ocean90
5 years ago

#9 @ocean90
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48318:

Posts: Provide a HiDPI version for the avatar used in post locked dialogs.

Props wpdesk, audrasjb, ocean90.
Fixes #39633.

Note: See TracTickets for help on using tickets.