WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Last modified 7 years ago

#39653 new enhancement

WP_Http_Cookie changes

Reported by: sebastianpisula's profile sebastian.pisula Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: HTTP API Keywords: reporter-feedback
Focuses: Cc:

Description

  1. The WordPress convention is to use underscores instead of camelCase for function and method change
  2. add new param to return array in get_attributes method
  3. change parse_url to wp_parse_url

Attachments (1)

39653.patch​ (3.4 KB) - added by sebastian.pisula 7 years ago.

Download all attachments as: .zip

Change History (2)

@sebastian.pisula
7 years ago

#1 @ocean90
7 years ago

  • Keywords reporter-feedback added

For 1) see ​https://make.wordpress.org/core/handbook/contribute/code-refactoring/.

Could you explain why you want to have name and value also be returned by get_attributes() and why the use of wp_parse_url() is necessary here?

Note: See TracTickets for help on using tickets.