Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#39721 closed defect (bug) (duplicate)

load[]= is being injected in the middle of handles for the load-scripts.php query string.

Reported by: roblesterjr Owned by:
Priority: normal Milestone:
Component: Script Loader Version: 4.7.2
Severity: normal Keywords:
Cc: Focuses: javascript, administration

Description

We found this issue while troubleshooting why the admin panel did not work while being passed through the Fastly service. For some reason, the issue doesn't cause any issues when used normally, but when passed through fastly, it causes the scripts not to be brought in.

This code:

$concat = str_split( $concat, 128 );
		$concat = 'load%5B%5D=' . implode( '&load%5B%5D=', $concat );

Found at line 1146 in script-loader.php looks to be unnecessary. When I comment it out, and just prepend load[]= to the $concat value, the admin scripts load fine without the extra injection.

Here is an example of what i'm finding in the query string:

jquery-ui-widget,jq&load%5B%5D=uery-ui-mouse,jquery-ui-sortable

We'd love it if you would address this. Thank you.

Change History (1)

#1 @SergeyBiryukov
10 years ago

  • Focuses ui removed
  • Milestone Awaiting Review
  • Resolutionduplicate
  • Status newclosed

Hi @roblesterjr, welcome to Trac! Thanks for the report.

This was previously discussed in #26886, but could not be reliably reproduced, so that ticket is now closed, but can be reopened if there's an indication of a bug in core. Could you please leave a comment on that ticket so we could keep the discussion in one place? Thank you!

Last edited 10 years ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.