Context Navigation

← Previous Ticket
Next Ticket →

#39770 closed defect (bug) (fixed)

Customize: Client-side notification error is unexpectedly cleared when no corresponding server-side validation

Reported by:	westonruter	Owned by:	westonruter
Priority:	low	Milestone:	4.7.4
Component:	Customize	Version:	4.6
Severity:	normal	Keywords:	has-patch commit fixed-major
Cc:		Focuses:

Description

Setting validation can be added both by adding a validate_callback (or sanitize_callback) on the server, or it can be added by adding an error Notification via JS (see also Make/Core post):

wp.customize( 'blogdescription', function( setting ) {
        var errorCode = 'capital_P_dangit';
        setting.bind( function( value ) {
                var notification;
                if ( /[Ww]ordpress/.test( value ) ) {
                        notification = new wp.customize.Notification(
                                errorCode,
                                {
                                        type: 'error',
                                        message: 'Capital P Dangit!'
                                }
                        );
                        setting.notifications.add( errorCode, notification );
                } else {
                        setting.notifications.remove( errorCode );
                }
        } );
} );

However, if the server lacks corresponding validation (which normally it should) the setting is currently marked as valid on the server and the error gets unexpectedly cleared on the client.

Attachments (1)

39770.0.diff (665 bytes ) - added by westonruter 9 years ago.

Download all attachments as: .zip

Change History (11)

@westonruter
9 years ago

Attachment 39770.0.diff added

#1 @westonruter
9 years ago

Keywords has-patch added

In order for returning an error/notification to work properly, api._handleSettingValidities needs to only remove notification errors that are no longer valid which are fromServer. See 39770.0.diff .

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.

9 years ago

#3 @westonruter
9 years ago

Milestone 4.7.3 → 4.7.4

This ticket was mentioned in Slack in #core by swissspidy. View the logs.

9 years ago

#6 @swissspidy
9 years ago

Owner set to westonruter
Status new → assigned

@westonruter Is this ready for a commit?

#7 @westonruter
9 years ago

Keywords commit added

#8 @westonruter
9 years ago

Resolution → fixed
Status assigned → closed

In 40319:

Customize: Prevent client-side validation from being cleared when no corresponding server-side validation is present.

See #36944.
Fixes #39770.

#9 @westonruter
9 years ago

Keywords fixed-major added
Priority normal → low
Resolution fixed
Status closed → reopened

Re-opening for consideration in 4.7.4.

#10 @swissspidy
9 years ago

Resolution → fixed
Status reopened → closed

In 40345:

Customize: Prevent client-side validation from being cleared when no corresponding server-side validation is present.

See #36944.
Fixes #39770.

Merges [40319] to the 4.7 branch.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#39770 closed defect (bug) (fixed)

Customize: Client-side notification error is unexpectedly cleared when no corresponding server-side validation

Description

Attachments (1)

Change History (11)

@westonruter 9 years ago

#1 @westonruter 9 years ago

This ticket was mentioned in ​Slack in #core by jeffpaul. ​View the logs. 9 years ago

#3 @westonruter 9 years ago

This ticket was mentioned in ​Slack in #core by swissspidy. ​View the logs. 9 years ago

This ticket was mentioned in ​Slack in #core by swissspidy. ​View the logs. 9 years ago

#6 @swissspidy 9 years ago

#7 @westonruter 9 years ago

#8 @westonruter 9 years ago

#9 @westonruter 9 years ago

#10 @swissspidy 9 years ago

Download in other formats:

@westonruter
9 years ago

#1 @westonruter
9 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.

9 years ago

#3 @westonruter
9 years ago

This ticket was mentioned in Slack in #core by swissspidy. View the logs.

9 years ago

This ticket was mentioned in Slack in #core by swissspidy. View the logs.

9 years ago

#6 @swissspidy
9 years ago

#7 @westonruter
9 years ago

#8 @westonruter
9 years ago

#9 @westonruter
9 years ago

#10 @swissspidy
9 years ago