#39860 closed defect (bug) (fixed)
Multiple Themes: Check for WP_Error before outputting `get_the_tag_list()`
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.5 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | has-patch needs-testing |
| Focuses: | Cc: |
Description
We've seen this error pop up on WordPress.com for multiple _s-based and default themes:
Catchable fatal error - Object of class WP_Error could not be converted to string
This happens because get_the_tag_list() can return an object of WP_Error and the theme doesn't account for it. Core handles it gracefully if the theme uses the_tags() instead.
Affected themes:
- Twenty Seventeen
- Twenty Fifteen
- Twenty Thirteen
- Twenty Twelve
- Twenty Eleven
- Twenty Ten
I propose we patch these to account for WP_Error. Two possible solutions:
- If echoing the output, switch to
the_tags(). - If returning the tags list, add a catch for
is_wp_error()in the function to avoid the fatal error.
I'll add some patches to get this started.
Attachments (4)
Change History (12)
#1
@
9 years ago
Twenty Sixteen is also affected; I opened a PR: https://github.com/WordPress/twentysixteen/pull/496
This ticket was mentioned in Slack in #core-themes by obenland. View the logs.
9 years ago
Note: See
TracTickets for help on using
tickets.
Check for is_wp_error() before outputting get_the_tag_list() in Twenty Fifteen