WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 7 months ago

Last modified 4 months ago

#39860 closed defect (bug) (fixed)

Multiple Themes: Check for WP_Error before outputting `get_the_tag_list()`

Reported by: sixhours Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

We've seen this error pop up on WordPress.com for multiple _s-based and default themes:

Catchable fatal error - Object of class WP_Error could not be converted to string

This happens because get_the_tag_list() can return an object of WP_Error and the theme doesn't account for it. Core handles it gracefully if the theme uses the_tags() instead.

Affected themes:

  • Twenty Seventeen
  • Twenty Fifteen
  • Twenty Thirteen
  • Twenty Twelve
  • Twenty Eleven
  • Twenty Ten

I propose we patch these to account for WP_Error. Two possible solutions:

  1. If echoing the output, switch to the_tags().
  2. If returning the tags list, add a catch for is_wp_error() in the function to avoid the fatal error.

I'll add some patches to get this started.

Attachments (4)

twentyfifteen.diff (685 bytes) - added by sixhours 4 years ago.
Check for is_wp_error() before outputting get_the_tag_list() in Twenty Fifteen
twentyseventeen.diff (841 bytes) - added by sixhours 4 years ago.
Check for is_wp_error() before outputting get_the_tag_list() in Twenty Seventeen
twentyten.diff (865 bytes) - added by sixhours 4 years ago.
Check for is_wp_error() before outputting get_the_tag_list() in Twenty Ten
39860.1.patch (3.0 KB) - added by davidakennedy 3 years ago.
Check for is_wp_error() before outputting get_the_tag_list().

Download all attachments as: .zip

Change History (12)

@sixhours
4 years ago

Check for is_wp_error() before outputting get_the_tag_list() in Twenty Fifteen

@sixhours
4 years ago

Check for is_wp_error() before outputting get_the_tag_list() in Twenty Seventeen

@sixhours
4 years ago

Check for is_wp_error() before outputting get_the_tag_list() in Twenty Ten

#1 @sixhours
4 years ago

Twenty Sixteen is also affected; I opened a PR: https://github.com/WordPress/twentysixteen/pull/496

#2 @swissspidy
4 years ago

  • Keywords has-patch needs-testing added
  • Version trunk deleted

This ticket was mentioned in Slack in #core-themes by obenland. View the logs.


4 years ago

@davidakennedy
3 years ago

Check for is_wp_error() before outputting get_the_tag_list().

#4 @davidakennedy
3 years ago

I combined the patches from @sixhours and moved the PR from Twenty Sixteen over.

See: https://github.com/WordPress/twentysixteen/pull/496

#5 @davidakennedy
3 years ago

  • Milestone changed from Awaiting Review to Future Release

#6 @ianbelanger
7 months ago

  • Resolution set to fixed
  • Status changed from new to closed

This appears to have already been fixed. Closing

#7 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov

In 47886:

Bundled Themes: Consistently check for WP_Error before outputting get_the_tag_list().

Some themes already had these checks in place as a result of [41756], but not others.

Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860.

#8 @SergeyBiryukov
4 months ago

  • Milestone changed from Future Release to 5.5
Note: See TracTickets for help on using tickets.