Opened 8 years ago
Closed 8 years ago
#40041 closed defect (bug) (fixed)
Use `markTestSkipped()` vs `echo` in REST API schema initialization tests
Reported by: | jeremyfelt | Owned by: | jeremyfelt |
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | 4.8 |
Component: | REST API | Keywords: | needs-patch |
Focuses: | rest-api | Cc: |
Change History (7)
This ticket was mentioned in Slack in #core by swissspidy. View the logs.
8 years ago
#4
@
8 years ago
- Milestone changed from 4.7.4 to 4.8
Moving out of the 4.7.4 milestone as it only affects tests and can be addressed in trunk as well.
#6
in reply to:
↑ 5
@
8 years ago
- Keywords dev-feedback removed
Replying to jnylen0:
We could also just remove these echo statements entirely.
This sounds right if no tests are being skipped. I don't think I looked close enough when opening the ticket to see what the echo
was actually communicating.
Note: See
TracTickets for help on using
tickets.
The only part of this test that we should skip is the fixture generation. The assertions there are still valuable.
I didn't see a clear way to accomplish this when I was working on it. Maybe we want to refactor this into two separate tests - one that does the assertions and another (skippable) test that does the fixture generation?