Context Navigation

← Previous Ticket
Next Ticket →

#40114 closed defect (bug) (invalid)

load_plugin_textdomain() no back compatibility

Reported by:	Tkama	Owned by:
Priority:	normal	Milestone:
Component:	I18N	Version:	4.7
Severity:	normal	Keywords:
Cc:		Focuses:

Description

load_plugin_textdomain() uses get_user_locale() function if is_admin()===true, but get_user_locale() introduced in WP 4.7. And what with back compatibility?..

So, if user have Wordpress less then 4.7 and any plugin has function load_plugin_textdomain() in admin area - user get PHP fatal error - use undefined function...

Is it ok?

Change History (5)

#1 @dingo_bastard
9 years ago

I have a plugin using load_plugin_textdomain(), and tested it on 4.2 version of WordPress, and the function didn't threw any errors. The get_user_locale() is used in a filter, so my bet is it's safe to use there...

#2 @Tkama
9 years ago

Resolution → wontfix
Status new → closed

#3 @Tkama
9 years ago

Oh, it's my mistake... If we have WP less then 4.7, then code of load_plugin_textdomain() will be another - without get_user_locale()...

#4 @ocean90
9 years ago

Milestone Awaiting Review
Resolution wontfix → invalid

#5 @SergeyBiryukov
9 years ago

Component Administration → I18N

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#40114 closed defect (bug) (invalid)

load_plugin_textdomain() no back compatibility

Description

Change History (5)

#1 @dingo_bastard 9 years ago

#2 @Tkama 9 years ago

#3 @Tkama 9 years ago

#4 @ocean90 9 years ago

#5 @SergeyBiryukov 9 years ago