WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#40272 new defect (bug)

Customize: Account for media queries in l10n.css

Reported by: swissspidy Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Customize Keywords: needs-patch
Focuses: ui Cc:
PR Number:

Description

Noticed while working on #40271 / #40152.

wp-admin/css/l10n.css contains some locale-specific CSS adjustments, some of them for the customizer. For example:

.locale-de-de #customize-header-actions .button {
	padding: 0 5px 1px; /* default 0 10px 1px */
}

Now, that default is correct — as long as you are not using the Customizer on a smaller device. There, the default padding is 6px 14px, not 0 10px 1px.

On an iPhone 6, that de_DE specific CSS looks like this:

https://cldup.com/8Zl2SQwmIT.png

As you can see, there's a clear lack of top and bottom padding.

Change History (3)

#1 @westonruter
3 years ago

@swissspidy is this because in de_DE the “Save & Publish” text spans two lines? Why is “Save & Publish” showing with the de_DE locale active?

#2 @swissspidy
3 years ago

Why is “Save & Publish” showing with the de_DE locale active?

That's fixed in #40271. But it also happens when the text is in de_DE and the de_DE body class is applied.

is this because in de_DE the “Save & Publish” text spans two lines?

Nope, it doesn't. At least not on mobile.

Here are some screenshots:

iPhone 6 screen size:

https://cldup.com/5ZymKaQy9z.png

https://cldup.com/qSNAseTmWW.png

iPhone 5 screen size:

https://cldup.com/4xBgn1FTiB.png

https://cldup.com/DGUUvi6vyM.png

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.