TwentySeventeen: customize-controls.js passes unused jQuery argument to an IIFE that accepts no arguments

[Christian1012]

The IIFE (Immediately Invoked Function Expression) in customize-controls.js looks like this:

(function() {
    // Do stuff
})( jQuery );

In the context of jQuery, this style is used to alias jQuery as $ within the function expression.

Example:

(function( $ ) {
    console.log( $( 'body' ) );
})( jQuery );

jQuery is not used in the function block, nor does the function expression accept an argument, so my recommendation would be to remove it. If there is a reason to pass jQuery as an argument, then the function expression should at least accept it as an argument.

[Christian1012]

40333.0.diff added.

[SergeyBiryukov]

Hi @Christian1012, welcome to WordPress Trac!

Thanks for the ticket and the patch! Sorry it took so long for someone to get back to you.

Looks like this was done for consistency with other files (where $ is used), or maybe as a copy/paste from those files. I have no objections to changing it though.

The same should be done for Twenty Nineteen's customize-controls.js as well.

[Hareesh Pillai]

Patch refreshed. Also, handled Twenty Nineteen's customize-controls.js

[williampatton]

I took a look at this ticket just now in passing and the patch refresh lgtm :)

[SergeyBiryukov]

In 45922:

Twenty Seventeen: Remove unused jQuery argument passed to an IIFE that accepts no arguments.

Props Christian1012, hareesh-pillai.
See #40333.

[SergeyBiryukov]

In 45923:

Twenty Nineteen: Remove unused jQuery argument passed to an IIFE that accepts no arguments.

Props Christian1012, hareesh-pillai.
Fixes #40333.