WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 months ago

Last modified 2 months ago

#40363 closed defect (bug) (fixed)

Remove `current_blog_` cache invalidation from `clean_blog_cache()`

Reported by: flixos90 Owned by: spacedmonkey
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: good-first-bug has-patch
Focuses: multisite Cc:

Description

clean_blog_cache() currently invalidates keys current_blog_{$blog->domain} and current_blog_{$blog->domain}_{$blog->path} of the site-options group. As far as I can see those keys are not used anywhere in Core (and have not been used for quite a while), so we should be able to remove them from that function.

Related: #40201 (more elaborate improvements of clean_blog_cache())

Attachments (1)

40363.patch (628 bytes) - added by spacedmonkey 3 years ago.

Download all attachments as: .zip

Change History (14)

@spacedmonkey
3 years ago

#1 @spacedmonkey
3 years ago

I checked and these cache keys haven't been used in core for sometime. It should be safe to remove them.

#2 @thamaraiselvam
3 years ago

I am also confirming that these keys are not used anywhere in the core. better to remove them.

#3 @thamaraiselvam
3 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core-multisite by spacedmonkey. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.


3 years ago

#6 @DrewAPicture
3 years ago

  • Owner set to spacedmonkey
  • Status changed from new to assigned

Assigning ownership to mark the good-first-bug as "claimed".

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.


3 years ago

#8 @flixos90
3 years ago

@jeremyfelt @johnjamesjacoby I am not sure, but I think I remember there were some concerns about removing these?

This ticket was mentioned in Slack in #core by sergey. View the logs.


2 months ago

#10 @SergeyBiryukov
2 months ago

Some history on these cache keys:

#11 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 46990:

Networks and Sites: Remove invalidation of unused cache keys in clean_blog_cache().

Props spacedmonkey, flixos90, thamaraiselvam.
Fixes #40363.

#12 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 5.4

#13 @SergeyBiryukov
2 months ago

In 46991:

Tests: Remove unused cache keys from data_get_site_caches().

Follow-up to [46990].

See #40363.

Note: See TracTickets for help on using tickets.