Typo in wp_kses_allowed_html()

[henry.wright]

There's a typo in the first occurrence of the wp_kses_allowed_html filter inside wp_kses_allowed_html(). The 2nd arg in the call to apply_filters() should read $tags, not $context.

This may confuse users of the filter.

[ketuchetan]

Made the typo correction.

[henry.wright]

@ketuchetan thanks for 40575.patch but it's not quite right. Even though I said $tags in the ticket description, it's not the variable to use. $allowedposttags and $allowedtags both hold "allowed HTML" at the point the filter runs.

[SergeyBiryukov]

Introduced in [21790], docs added in [27739].

Given that this instance of the filter is only applied if is_array( $context ) and provides explicit as the actual context, the usage appears to be correct, it just needs to be documented better.

The function docs should mention that $context itself can be an array of allowed tags.

[henry.wright]

@SergeyBiryukov agreed. If the argument passed to wp_kses_allowed_html() is an array, the filter in question will run and $context will be that passed array. It's worth making it clear in the inline docs for the filter that the array won't actually be "context" data, instead it'll be "allowed tags" data.

Of course, in the wild, what is passed to wp_kses_allowed_html() can be anything, but I'm basing the above on what the function is intended to accept (described in the function signature and inline docs):

 * @param string $context The context for which to retrieve tags.
 *                        Allowed values are post, strip, data,entities, or
 *                        the name of a field filter such as pre_user_description.
 * @return array List of allowed tags and their allowed attributes.
 */
function wp_kses_allowed_html( $context = '' ) {

[DrewAPicture]

@bor0 Thanks for the patches!

[DrewAPicture]

In 40950:

Docs: Adjust notation for the $context parameter in the DocBlocks for the wp_kses_allowed_html() function and its associated wp_kses_allowed_html filter.

$context|$allowedtags can be either a string or array.

Props bor0.
Fixes #40575.