WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 months ago

#40720 closed enhancement (fixed)

REST API: more ambiguous strings ("The object...")

Reported by: jnylen0 Owned by: SergeyBiryukov
Milestone: 5.8 Priority: normal
Severity: normal Version: 4.7
Component: REST API Keywords: good-first-bug has-patch
Focuses: rest-api Cc:

Description

[39342] clarified a lot of strings like "The caption for the resource." using more specific object types. However, there are still alot left that use "object" instead of "resource":

https://gist.github.com/nylen/359d02d837c64911760a8b95217e53d1

We should also update these to use more specific object types.

cc @ramiy in case you are interested in working on this for 4.8 - but to make it in, it needs a patch in the next day or so.

Change History (8)

#1 @ocean90
4 years ago

  • Keywords i18n-change removed

Removed i18n-change because it's only required during string freezes.

#2 @ramiy
4 years ago

@jnylen0 thanks for the CC, I will do my part like I do before every major release. But my audit depends on translate.wordpress.org. When 4.8 strings will be imported to glotpress I will commit my patches.

#3 @TimothyBlynJacobs
11 months ago

  • Keywords good-first-bug added

#4 @lephleg
6 months ago

Hello @jnylen0, made the appropriate updates.

Left the following untouched though, as they are indeed referring to more abstract types:

https://gist.github.com/lephleg/f59a5f9ad32e37c96c2ad4a3ef163ee4

This ticket was mentioned in PR #1098 on WordPress/wordpress-develop by lephleg.


6 months ago

  • Keywords has-patch added; needs-patch removed

Updates "object" ambiguous strings in various locations in REST API controllers.

Trac ticket: https://core.trac.wordpress.org/ticket/40720

#6 @lephleg
6 months ago

@TimothyBlynJacobs is anyone reviewing this? Would you require any further changes?

#7 @SergeyBiryukov
6 months ago

  • Milestone changed from Future Release to 5.8

#8 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51000:

REST API: Update “object” strings to use the appropriate nouns.

This updates route arguments and schema descriptions to use more specific object types for clarity.

Follow-up to [39342].

Props lephleg, jnylen0.
Fixes #40720.

Note: See TracTickets for help on using tickets.