WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#40939 closed defect (bug) (fixed)

Incorrect placeholder in translator comment in WP_Community_Events->get_events

Reported by: tfirdaus's profile tfirdaus Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: minor Version: 4.8
Component: I18N Keywords: has-patch
Focuses: administration Cc:

Description

Shouldn’t be the type specifier in the translator comment %d instead of %s?

Attachments (2)

Screen Shot 2017-06-07 at 5.38.57 PM.png​ (111.4 KB) - added by tfirdaus 7 years ago.
Preview in GlotPress
40939.diff​ (724 bytes) - added by Soean 7 years ago.
40939.diff Replaces the %s with %d in the translator comment.

Download all attachments as: .zip

Change History (10)

@tfirdaus
7 years ago

Preview in GlotPress

This ticket was mentioned in ​Slack in #polyglots by tfirdaus. ​View the logs.
7 years ago

@Soean
7 years ago

40939.diff Replaces the %s with %d in the translator comment.

#2 @Soean
7 years ago

  • Keywords has-patch added
  • Severity changed from normal to minor
  • Summary changed from wp-admin/includes/class-wp-communit-events.php:111 Inconsistent type specifier to Incorrect placeholder in translator comment in WP_Community_Events->get_events

#3 @iandunn
7 years ago

40939.diff​ looks good to me.

#4 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.8.1

#5 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#6 @swissspidy
7 years ago

#40944 was marked as a duplicate.

#7 @SergeyBiryukov
7 years ago

  • Milestone changed from 4.8.1 to 4.9

#8 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 40909:

I18N: Correct translator comment for response error message in WP_Community_Events::get_events().

Props Soean, tfirdaus.
Fixes #40939.

Note: See TracTickets for help on using tickets.