Opened 8 years ago
Closed 8 years ago
#41135 closed task (blessed) (fixed)
Backport PHP 7.1 fixes
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9 | Priority: | low |
Severity: | critical | Version: | 4.6 |
Component: | General | Keywords: | has-patch |
Focuses: | Cc: |
Description
In #37071, two fixes were made for issues related to PHP 7.1. The most visible is [37697] which avoids a fatal error when trying to log in, meaning users are unable to access the admin area.
[37697] and [37720] should be backported so that, at a minimum, users can at least log in to pre-4.6 installations when running PHP 7.1+.
Let's backport this to as many previous releases as possible where those two changesets apply cleanly. A separate patch should be created for each branch.
Attachments (6)
Change History (14)
#1
@
8 years ago
- Keywords dev-feedback added; needs-patch removed
Attached patches for 4.4 and 4.5 branches.
For each branch, I attached separate patches for each changeset, and one combined patch of those two.
I tested the same patch up to 4.1, and they do apply with only minor offsets.
#2
@
8 years ago
- Keywords has-patch added
- Owner set to ayeshrajans
- Status changed from new to assigned
Assigning ownership to mark the good-first-bug
as "claimed".
#3
@
8 years ago
- Keywords dev-feedback removed
- Owner changed from ayeshrajans to johnbillion
- Status changed from assigned to reviewing
Changeset 37697 backport for 4.5 branch