WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#41135 closed task (blessed) (fixed)

Backport PHP 7.1 fixes

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.9 Priority: low
Severity: critical Version: 4.6
Component: General Keywords: has-patch
Focuses: Cc:
PR Number:

Description

In #37071, two fixes were made for issues related to PHP 7.1. The most visible is [37697] which avoids a fatal error when trying to log in, meaning users are unable to access the admin area.

[37697] and [37720] should be backported so that, at a minimum, users can at least log in to pre-4.6 installations when running PHP 7.1+.

Let's backport this to as many previous releases as possible where those two changesets apply cleanly. A separate patch should be created for each branch.

Attachments (6)

41135-backport-37697-4-5.patch (855 bytes) - added by ayeshrajans 2 years ago.
Changeset 37697 backport for 4.5 branch
41135-backport-37720-wp4-5.patch (849 bytes) - added by ayeshrajans 2 years ago.
Changeset 37720 backport for branch 4.5
41135-backport-combined-wp4-5.patch (1.6 KB) - added by ayeshrajans 2 years ago.
Changesets 37720 and 37697 backport for 4.5 branch, combined patch
41135-backport-37697-4-4.patch (839 bytes) - added by ayeshrajans 2 years ago.
Changeset 37697 backport for 4.4 branch
41135-backport-37720-wp4-4.patch (849 bytes) - added by ayeshrajans 2 years ago.
Changeset 37720 backport for branch 4.4
41135-backport-combined-wp4-4.patch (1.6 KB) - added by ayeshrajans 2 years ago.
Changesets 37720 and 37697 backport for 4.4 branch, combined patch

Download all attachments as: .zip

Change History (14)

@ayeshrajans
2 years ago

Changeset 37697 backport for 4.5 branch

@ayeshrajans
2 years ago

Changeset 37720 backport for branch 4.5

@ayeshrajans
2 years ago

Changesets 37720 and 37697 backport for 4.5 branch, combined patch

@ayeshrajans
2 years ago

Changeset 37697 backport for 4.4 branch

@ayeshrajans
2 years ago

Changeset 37720 backport for branch 4.4

@ayeshrajans
2 years ago

Changesets 37720 and 37697 backport for 4.4 branch, combined patch

#1 @ayeshrajans
2 years ago

  • Keywords dev-feedback added; needs-patch removed

Attached patches for 4.4 and 4.5 branches.
For each branch, I attached separate patches for each changeset, and one combined patch of those two.

I tested the same patch up to 4.1, and they do apply with only minor offsets.

#2 @DrewAPicture
2 years ago

  • Keywords has-patch added
  • Owner set to ayeshrajans
  • Status changed from new to assigned

Assigning ownership to mark the good-first-bug as "claimed".

#3 @johnbillion
2 years ago

  • Keywords dev-feedback removed
  • Owner changed from ayeshrajans to johnbillion
  • Status changed from assigned to reviewing

This ticket was mentioned in Slack in #core-php by spacedmonkey. View the logs.


2 years ago

#5 @johnbillion
2 years ago

  • Keywords good-first-bug removed

#6 @johnbillion
2 years ago

In 41128:

General: Backport PHP 7.1 fixes to the 4.5 branch to avoid fatal errors and warnings.

Props simonvik, ayeshrajans

See #41135

#7 @johnbillion
2 years ago

In 41129:

General: Backport PHP 7.1 fixes to the 4.4 branch to avoid fatal errors and warnings.

See #41135

#8 @johnbillion
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.