![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 years ago
Closed 8 years ago
#41160 closed defect (bug) (fixed)
Placeholder height too big in Menus page in WordPress
| Reported by: | alexvorn2 | Owned by: | afercia |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.1 |
| Component: | Menus | Version: | 3.6 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | ui, administration |
Description
We need to decrease the height of the placeholder.
Maybe the latest jQuery made them bigger who knows.
Please look at the video I uploaded on youtube that shows what is the problem.
Attachments (2)
Change History (11)
#2
@
9 years ago
- Focuses administration added
- Keywords has-patch added; needs-patch removed
@alexvorn2 thanks for reporting! I've attached an initial patch for this.
#5
@
8 years ago
- Milestone 5.0 → 5.1
Switching milestone due to the focus on the new editor (Gutenberg) for WordPress 5.0.
#6
@
8 years ago
- Owner set to
- Status new → assigned
- Version 4.8 → 3.6
After a bit of code archeology, seems to me this happens since the admin redesign in 3.6 :) where the top margin of .menu-item-bar was decreased from 13px to 9px but the top margin of the .sortable-placeholder stayed to 13px. These margins need to have the same value to avoid the "jumpiness" when dragging items. Patch incoming.
#7
@
8 years ago
Also the sub-items need to have their top margin decreased, it's still margin-top: 13px;.
#8
@
8 years ago
For clarity, see in the GIF below the bug 41160.2.diff addresses: notice the "jumpiness" of the elements below the ones being dragged and their margins changing while dragging.
So to fix this we need -2px (to remove 2 pixels) from placeholder.