WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 6 months ago

#41160 closed defect (bug) (fixed)

Placeholder height too big in Menus page in WordPress

Reported by: alexvorn2 Owned by: afercia
Milestone: 5.1 Priority: normal
Severity: normal Version: 3.6
Component: Menus Keywords: has-patch
Focuses: ui, administration Cc:

Description

We need to decrease the height of the placeholder.

Maybe the latest jQuery made them bigger who knows.

Please look at the video I uploaded on youtube that shows what is the problem.

https://www.youtube.com/watch?v=jSnGVJGpqzc

Attachments (2)

41160.diff (632 bytes) - added by welcher 2 years ago.
Intial Patch
41160.2.diff (644 bytes) - added by afercia 6 months ago.

Download all attachments as: .zip

Change History (11)

#1 @alexvorn2
2 years ago

  • Keywords needs-patch added

So to fix this we need -2px (to remove 2 pixels) from placeholder.

@welcher
2 years ago

Intial Patch

#2 @welcher
2 years ago

  • Focuses administration added
  • Keywords has-patch added; needs-patch removed

@alexvorn2 thanks for reporting! I've attached an initial patch for this.

#3 @welcher
21 months ago

  • Focuses ui added
  • Keywords dev-feedback added
  • Type changed from enhancement to defect (bug)

#4 @welcher
20 months ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 5.0

#5 @peterwilsoncc
9 months ago

  • Milestone changed from 5.0 to 5.1

Switching milestone due to the focus on the new editor (Gutenberg) for WordPress 5.0.

#6 @afercia
6 months ago

  • Owner set to afercia
  • Status changed from new to assigned
  • Version changed from 4.8 to 3.6

After a bit of code archeology, seems to me this happens since the admin redesign in 3.6 :) where the top margin of .menu-item-bar was decreased from 13px to 9px but the top margin of the .sortable-placeholder stayed to 13px. These margins need to have the same value to avoid the "jumpiness" when dragging items. Patch incoming.

#7 @afercia
6 months ago

Also the sub-items need to have their top margin decreased, it's still margin-top: 13px;.

@afercia
6 months ago

#8 @afercia
6 months ago

For clarity, see in the GIF below the bug 41160.2.diff addresses: notice the "jumpiness" of the elements below the ones being dragged and their margins changing while dragging.

http://cldup.com/DQ7z8DYg_j.gif

#9 @afercia
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44567:

Menus: Make menu items not jump while dragging items.

Props alexvorn2, welcher, afercia.
Fixes #41160.

Note: See TracTickets for help on using tickets.