Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#41221 closed defect (bug) (fixed)

Throw error notice after wp-header-end

Reported by: shivapoudel's profile shivapoudel Owned by: swissspidy's profile swissspidy
Milestone: 5.1 Priority: normal
Severity: normal Version: 4.8
Component: Upgrade/Install Keywords: shiny-updates has-patch
Focuses: ui, javascript, administration Cc:

Description

Append admin notice for AJAX updates after wp-header-end

Attachments (6)

41221.diff (756 bytes) - added by shivapoudel 8 years ago.
Display admin AJAX error notice after wp-header-end
Capture.PNG (398.7 KB) - added by shivapoudel 8 years ago.
Error Image
Screenshot-1.png (31.2 KB) - added by shivapoudel 8 years ago.
Browse Plugins > Recently active section
Screenshot-2.png (31.2 KB) - added by shivapoudel 8 years ago.
Select Delete in Bulk action without any selection there
Screenshot-3.png (41.2 KB) - added by shivapoudel 8 years ago.
After clicking submit you will be throw error which this Patch resolves :)
Screenshot-4.png (34.6 KB) - added by shivapoudel 8 years ago.
After implementation of the patch it will look like this :)

Download all attachments as: .zip

Change History (13)

@shivapoudel
8 years ago

Display admin AJAX error notice after wp-header-end

@shivapoudel
8 years ago

Error Image

#1 @swissspidy
8 years ago

  • Component changed from Administration to Upgrade/Install
  • Keywords shiny-updates has-patch added

#2 @shivapoudel
8 years ago

@swissspidy Will this be patched in upcoming WordPress 4.9 version or not, Please do reply :)

#3 @swissspidy
8 years ago

  • Keywords needs-screenshots added

It's a bit late for 4.9.

Can you explain a bit on why this change is needed and how things look like without the patch?

@shivapoudel
8 years ago

Browse Plugins > Recently active section

@shivapoudel
8 years ago

Select Delete in Bulk action without any selection there

@shivapoudel
8 years ago

After clicking submit you will be throw error which this Patch resolves :)

#4 @shivapoudel
8 years ago

  • Keywords needs-screenshots removed

Hey @swissspidy I was missing the follow up emails for this ticket or was located somewhere in my inbox. Anyway sorry for the belated reply :)

Since reporting this ticket I have some modification hardly but today I will illustrate the simply way and what this patch does.

First I will surf my Development environment Plugins page > Recently active section.
Note: Since I have only WooCommerce in this section I will prefer this for steps to be clear :)

Without any selection I will choose Delete in bulk actions and will submit for AJAX process.
And it will throw the error message regarding no selection for delete action. AND this patch is especially for this step.

AFAIK this bug was after wp-header-end implementation maybe on 4.8 and punting this patch in 4.9 will make sense. This will not be any life breaking change IMO.

Thanks and sorry for the belated reply!

@shivapoudel
8 years ago

After implementation of the patch it will look like this :)

#5 @swissspidy
8 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to swissspidy
  • Status changed from new to assigned

Got it, thanks!

#6 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42700:

Administration: Make sure wp.updates.addAdminNotice is displayed after the page header and does not unexpectedly push down "Add New" and other buttons.

Props shivapoudel.
Fixes #41221.

#7 @johnbillion
7 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.