Throw error notice after wp-header-end

[shivapoudel]

Append admin notice for AJAX updates after wp-header-end

[shivapoudel]

Display admin AJAX error notice after wp-header-end

[shivapoudel]

Error Image

[shivapoudel]

@swissspidy Will this be patched in upcoming WordPress 4.9 version or not, Please do reply :)

[swissspidy]

It's a bit late for 4.9.

Can you explain a bit on why this change is needed and how things look like without the patch?

[shivapoudel]

Browse Plugins > Recently active section

[shivapoudel]

Select Delete in Bulk action without any selection there

[shivapoudel]

After clicking submit you will be throw error which this Patch resolves :)

[shivapoudel]

Hey @swissspidy I was missing the follow up emails for this ticket or was located somewhere in my inbox. Anyway sorry for the belated reply :)

Since reporting this ticket I have some modification hardly but today I will illustrate the simply way and what this patch does.

First I will surf my Development environment Plugins page > Recently active section. Note: Since I have only WooCommerce in this section I will prefer this for steps to be clear :)

Without any selection I will choose Delete in bulk actions and will submit for AJAX process. And it will throw the error message regarding no selection for delete action. AND this patch is especially for this step.

AFAIK this bug was after wp-header-end implementation maybe on 4.8 and punting this patch in 4.9 will make sense. This will not be any life breaking change IMO.

Thanks and sorry for the belated reply!

[shivapoudel]

After implementation of the patch it will look like this :)

[swissspidy]

Got it, thanks!

[SergeyBiryukov]

In 42700:

Administration: Make sure wp.updates.addAdminNotice is displayed after the page header and does not unexpectedly push down "Add New" and other buttons.

Props shivapoudel.
Fixes #41221.