![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#41274 closed defect (bug) (fixed)
Improve discoverability of link URL in Image widget.
| Reported by: | stefanimhoff | Owned by: | westonruter |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.9 |
| Component: | Widgets | Version: | 4.8 |
| Severity: | normal | Keywords: | has-patch commit has-screenshots |
| Cc: | Focuses: |
Description
Hi,
I want to use the new Image-Widget from WordPress 4.8. I define a Link on the Image, but after safing every spacial character like .:/?# are striped from the URL.
The a href is also not inserted in the DOM around the Image nor Title.
Do you need further information?
Best Regards,
Stefan
Attachments (4)
Change History (23)
#2
@
9 years ago
@westonruter One excample is http://www.ecocamping.net/
#3
@
9 years ago
@stefanimhoff I think you may be entering the URL in the incorrect field. See image-url-field.png.
#4
@
9 years ago
- Keywords reporter-feedback removed
- Resolution → invalid
- Status new → closed
Ohh, sorry. Seems to be a typical layer 8 Problem...
Thank yoe very much!
Best Regards, Stefan
This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.
9 years ago
#7
@
9 years ago
@stefanimhoff we are exploring some approaches to make the linking of images in the widget a bit more discoverable. If you have time I would love to have some feedback on the following designs being considered:
https://cloudup.com/cTX3XurZQBJ
The code to implement the third option is here if you are interested in testing it out: https://github.com/xwp/wordpress-develop/pull/243
#8
@
9 years ago
- Milestone → 4.9
- Resolution invalid
- Status closed → reopened
We can use this ticket for improving the usability.
#9
@
9 years ago
It is a great idea improving the usability.
@timmydcrawford I personally prefer the fourth solution, because most time I want to set more options (Relationships and open in a new window...). I don't know, if I would use third proposal very often, because of the additional options...
In the end linking Images will be standard-stuff: Web is meant to be linked ;)
#10
@
9 years ago
- Keywords has-patch added
- Owner set to
- Status reopened → reviewing
@timmydcrawford please add commit once you've confirmed 41274.0.diff.
#11
@
9 years ago
- Summary Links in Image Widget not working in WordPress 4.8 → Improve discoverability of link URL in Image widget.
@stefanimhoff what tis the full value you are supplying in the URL field? Note that it expects an actual URL, so beginning with
http://orhttps://. It usesesc_url_raw()to sanitize the URL.