Opened 8 years ago
Closed 7 years ago
#41380 closed defect (bug) (fixed)
Add missing docs for the $data parameter for WP_Http::browser_redirect_compatibility()
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | HTTP API | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
Documentation needs improvement.parameter passed but not defined.
Attachments (1)
Change History (10)
This ticket was mentioned in Slack in #core by ronak.ganatra. View the logs.
8 years ago
#5
@
8 years ago
- Owner set to DrewAPicture
- Resolution set to fixed
- Status changed from new to closed
In 41218:
#6
@
8 years ago
- Milestone changed from Awaiting Review to 4.9
Hi @ronakganatra, thanks for the patch. I've gone ahead and merged part of your patch and wanted to give you a couple of pointers for future tickets:
1) It would be very helpful if you could try to write more specific ticket summaries when submitting to trac in the future. I went ahead and updated it for you here :-)
2) It would also be helpful to generate your patches from the WordPress root instead of the directory the file is located in. This is because most core contributors will be using tools like the grunt patch tool to apply patches, which means patches not generated from the root may not apply correctly.
#7
@
8 years ago
- Summary changed from Documentation needs improvement. to Add missing docs for the $data parameter for WP_Http::browser_redirect_compatibility()
#8
@
8 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
This description appears to be a copy/paste from wp_cache_add()
,
The $data
argument of WP_Http::browser_redirect_compatibility()
has nothing to do with cache, appears to be unused and could probably be deprecated to avoid further confusion. Introduced in [37428].
documentation added for parameter which is passed but not defined.