Make WordPress Core

Opened 7 years ago

Closed 20 months ago

Last modified 19 months ago

#41474 closed enhancement (fixed)

Feature Request: Download Media button from Attachment Details Page

Reported by: countrymusicchicago's profile countrymusicchicago Owned by: joedolson's profile joedolson
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch commit needs-user-docs
Focuses: ui, administration Cc:

Description

Hello,

Sorry if this has been posted but would love a simple "Download Media" button or link from the media Attachment Details lightbox popup. This this is super simple yet would be helpful if you are trying to simply grab a photo that is in your WP media library.

https://swinterroth.com/wp-content/uploads/2017/07/Screen-Shot-2017-07-28-at-9.26.45-AM-squashed.png

Attachments (4)

Screen Shot 2017-07-28 at 9.26.45 AM-squashed.png (65.3 KB) - added by countrymusicchicago 7 years ago.
Sample of request
41474.diff (1.3 KB) - added by joedolson 20 months ago.
Add Download File in modal & media edit screens
41474-edit-screen.png (21.8 KB) - added by joedolson 20 months ago.
New link in edit screen
41474-edit-modal.png (22.1 KB) - added by joedolson 20 months ago.
Download link in modal

Download all attachments as: .zip

Change History (21)

This ticket was mentioned in Slack in #core-media by mike. View the logs.


6 years ago

#2 @kirasong
6 years ago

  • Keywords 2nd-opinion needs-patch added
  • Version changed from 4.8 to trunk

Hi @countrymusicchicago!

Sorry it took so long to reply to this. I like this idea. Seems like a simple and useful enhancement.
Adding the second opinion tag to get others' thoughts on it.

#3 @pento
6 years ago

  • Version trunk deleted

This ticket was mentioned in Slack in #core-media by joedolson. View the logs.


22 months ago

#5 @antpb
22 months ago

  • Milestone changed from Awaiting Review to 6.2
  • Owner set to antpb
  • Status changed from new to assigned

This would be a great addition to WordPress 6.2! Going to move into the milestone so we can try to get this in. Thanks for the suggestion @countrymusicchicago, I didnt even realize I've been working around this for years. :D

#6 @antpb
22 months ago

  • Owner changed from antpb to joedolson

@joedolson
20 months ago

Add Download File in modal & media edit screens

#7 @joedolson
20 months ago

  • Keywords has-patch needs-testing added; 2nd-opinion needs-patch removed

@joedolson
20 months ago

New link in edit screen

@joedolson
20 months ago

Download link in modal

#8 @amin7
20 months ago

Test Report

This report validates that the indicated patch addresses the issue.
Patch tested:
https://core.trac.wordpress.org/attachment/ticket/41474/41474.diff


Environment


OS: Windows 10 version 22H2
Web Server: Nginx
PHP: 7.4.30
WordPress: 6.2-alpha-54642-src
Browser: Chrome 109.0.5414.87
Theme: Twenty Twenty-Three
Active Plugins: No plugins activated.

Before Patch


Edit screen: https://d.pr/i/RzMwrx
Edit Modal: https://d.pr/i/98zSZg

After Patch


Edit Modal: https://d.pr/i/NT4JqD
Edit Screen: https://d.pr/i/WEycmv

Actual Results


✅ patch is working as mentioned.

#9 @joedolson
20 months ago

  • Keywords commit added; needs-testing removed

This ticket was mentioned in PR #3932 on WordPress/wordpress-develop by @joedolson.


20 months ago
#10

Adds download links for media item individual views.

Trac ticket: https://core.trac.wordpress.org/ticket/41474

#11 @joedolson
20 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 55156:

Media: Add download link to media modal and attachment details.

Make it easier for users to download their uploaded media by providing a download link on the attachment details screen and in the media modal.

Props countrymusicchicago, joedolson, amin7
Fixes #41474.

#12 @pbiron
20 months ago

This is a really nice feature.

Would folks also like a Download row action in the Media Library list mode? I can do a quick patch for that if so!

#13 follow-up: @joedolson
20 months ago

I thought about that, but felt that the row actions can get really busy. Go ahead and open a new ticket to suggest extending that, though. Maybe if we shortened 'Copy URL to Clipboard' to just 'Copy URL', it wouldn't feel as chaotic.

#14 in reply to: ↑ 13 @pbiron
20 months ago

Replying to joedolson:

I thought about that, but felt that the row actions can get really busy. Go ahead and open a new ticket to suggest extending that, though. Maybe if we shortened 'Copy URL to Clipboard' to just 'Copy URL', it wouldn't feel as chaotic.

Ask and Ye Shall Receive: #57574.

#15 @milana_cap
19 months ago

  • Keywords add-to-field-guide needs-user-docs added

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


19 months ago

#17 @milana_cap
19 months ago

  • Keywords add-to-field-guide removed
Note: See TracTickets for help on using tickets.