WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 8 months ago

#41637 closed defect (bug) (fixed)

i18n: Merge similar translation strings for non-hierarchical taxonomy

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:

Description

Merge two similar translation strings:

  • This taxonomy is not hierarchical so you can't set a parent. - used in rest api (x2)
  • Cannot set parent term, taxonomy is not hierarchical. - used in xmlrpc

See the screenshot from GlotPress and the patch merging the strings.

Attachments (4)

parent-term-non-hierarchical-taxonomy-1.png (70.0 KB) - added by ramiy 10 months ago.
parent-term-non-hierarchical-taxonomy-2.png (24.6 KB) - added by ramiy 10 months ago.
41637.patch (675 bytes) - added by ramiy 10 months ago.
41637.2.patch (772 bytes) - added by netweb 8 months ago.

Download all attachments as: .zip

Change History (9)

@ramiy
10 months ago

#1 @SergeyBiryukov
10 months ago

  • Milestone changed from Awaiting Review to 4.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41574:

I18N: Merge two similar "Cannot set parent term" error strings.

Props ramiy.
Fixes #41637.

@netweb
8 months ago

#3 @netweb
8 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening, per https://travis-ci.org/WordPress/wordpress-develop/builds/278799825

There was 1 failure:


1) Tests_XMLRPC_wp_editTerm::test_parent_for_nonhierarchical

Failed asserting that two strings are equal.

--- Expected

+++ Actual

@@ @@

-'This taxonomy is not hierarchical so you can't set a parent.'

+'Cannot set parent term, taxonomy is not hierarchical.'


/home/travis/build/WordPress/wordpress-develop/tests/phpunit/tests/xmlrpc/wp/editTerm.php:89

Patch 41637.2.patch updates the tests string to match the string added in [41574]

This ticket was mentioned in Slack in #core by netweb. View the logs.


8 months ago

#5 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41575:

XML-RPC: Update the string in test_parent_for_nonhierarchical() to match the string added in [41574].

Props netweb.
Fixes #41637.

Note: See TracTickets for help on using tickets.