WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#41640 closed defect (bug) (fixed)

Missing mejs.MediaElement reference in 4.9

Reported by: programmin's profile programmin Owned by: westonruter's profile westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Media Keywords: reporter-feedback needs-testing
Focuses: javascript Cc:

Description

In Wordpress 4.9 preview currently anything referencing mejs.MediaElement breaks as it's undefined. Missing a mediaelement plugin? or is this a change in MEJS itself?

Change History (8)

#1 @rafa8626
7 years ago

Let me check that but I think it's a change on MEJS itself

#2 @rafa8626
7 years ago

@programmin I have submitted a PR with this fix; please test ​https://github.com/xwp/wordpress-develop/pull/248

#3 @westonruter
7 years ago

  • Milestone changed from Awaiting Review to 4.9

#4 @joemcgill
7 years ago

  • Keywords reporter-feedback needs-testing added

This ticket was mentioned in ​Slack in #core-media by desrosj. ​View the logs.
7 years ago

#6 @desrosj
7 years ago

Related #39686

#7 @joemcgill
7 years ago

  • Owner set to westonruter
  • Status changed from new to assigned

#8 @westonruter
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41320:

Media: Upgrade MediaElement.js to 4.2.5-74e01a40 fixing missing mejs.MediaElement reference.

ALso fixes:

  • Accessibility for volume control
  • Progress bar tooltip positioning and dimensions correctly set for media with long duration
  • Better codec checking
  • Minor CSS fix to avoid flickering effect on volume control

Props rafa8626.
See #39686.
Fixes #41640.

Note: See TracTickets for help on using tickets.