Unit test for wp_auth_check()

[pbearne]

Hi All

Just some Unit tests for function wp_auth_check() from functions.php

Paul

[pbearne]

Unit tests

[birgire]

Hi @pbearne

It looks good to me.

Just two remarks:

• Missing @ticket annotation for each method? ... or is that only for bug referencing?
• as the modified global state can affect other test methods, shouldn't we restore it, if we modify it?

I updated the patch with this in mind in 41860.2.patch​

[birgire]

This should be the correct file ;-)

[pbearne]

@birgire that looks better :-)

Good catches

[pbearne]

This ticket patch as patch of Virtual Contrib 2 core Meetup

​https://www.youtube.com/watch?v=xoQkp_aZzfE
​https://www.meetup.com/The-Ottawa-WordPress-Group/events/242253849/
​https://www.meetup.com/WPToronto/events/243121890/

[birgire]

@pbearne great to see a video of the patch coding, thanks for sharing

[birgire]

Updated a little bit in 41860.4.patch​:

• moved the clean-up before the assertion - see here in an unrelated ticket: 42044#comment:1.
• changed assertEquals() to assertSame(), to avoid null, empty string and false being treated equally.

[johnbillion]

In 41710:

Login and Registration: Add unit tests for wp_auth_check().

Props pbearne, birgire

Fixes #41860