wpdb->prepare() method inhibits argument numbering

[ruud@…]

Since 4.8.2 an additional line was added to escape any unescaped percents:

$query = preg_replace( '/%(?:%|$|([^dsF]))/', '%%\\1', $query ); // escape any unescaped percents 

this however prohibits the use of numbered arguments like in this query from Yoast SEO plugin:

$query = $wpdb->prepare( 'SELECT COUNT( id ) AS incoming, target_post_id AS post_id
			  FROM %2$s
			 WHERE target_post_id IN( %3$s )
		  GROUP BY target_post_id',
			$this->get_table_name(),
			$storage->get_table_name(),
			implode( ', ', $post_ids )
		);

[ocean90]

Yoast SEO is actually doing it wrong since numbered arguments are not supported by wpdb::prepare(). There's a pending PR to fix this.

Closing as a duplicate #41925 which requests to add support for numbered arguments.

[ruud@…]

Thanks Dominik for the feedback.

[ocean90]

#41929 was marked as a duplicate.