Whitelist Flac Files

[blobfolio]

[Flac](​https://en.wikipedia.org/wiki/FLAC) is a popular, lossless audio compression format. It is natively supported by Chrome and Firefox, and support is also due to land in Edge 16. (See: ​https://caniuse.com/#search=flac)

I do not see any reason to prevent users from uploading media of this type by default.

[blobfolio]

Add flac to the default wp_get_mime_types() list.

[blobfolio]

Add flac to ext2type and wp_audio_extensions defaults.

[joemcgill]

This looks good, but unfortunately missed the 4.9 deadline. Let's get this in for 4.9.1.

[wonderboymusic]

what do these files look like when used with MediaElement? wp_audio_extensions filter mainly exists to whitelist ME-capable types

[blobfolio]

Just a refresh built against the current source.

[blobfolio]

Picture showing embedded Flac media

[blobfolio]

Replying to wonderboymusic:

what do these files look like when used with MediaElement? wp_audio_extensions filter mainly exists to whitelist ME-capable types

I attached a screenshot. ME.js draws the usual widget. The raw HTML looks like it should too.

[blobfolio]

Another refresh. :)

[joemcgill]

42225.4.diff​ is looking good to me. It would be nice to update/add unit tests here where it makes sense, otherwise it's ready to go in.

[blobfolio]

Add unit test.

[blobfolio]

File for unit tests, place in tests/phpunit/data/uploads/

[blobfolio]

Move unit test to "Test a few additional file types on single sites." block; seems more appropriate.

[blobfolio]

I added a unit test to make sure Flac files get through wp_check_filetype_and_ext() under default conditions.

[SergeyBiryukov]

In 42451:

Media: Add flac to the list of allowed file types.

Props blobfolio.
Fixes #42225.

[SergeyBiryukov]

In 42452:

Media: Add flac to the list of allowed file types.

Props blobfolio.
Merges [42451] to the 4.9 branch.
Fixes #42225.

[SergeyBiryukov]

In 42453:

Media: Add small-audio.flac for a unit test added in [42451].

See #42225.

[SergeyBiryukov]

In 42454:

Media: Add small-audio.flac for a unit test added in [42451].

Merges [42453] to the 4.9 branch.
See #42225.