Opened 9 years ago
Closed 8 years ago
#42341 closed defect (bug) (fixed)
Add sandbox attribute to Customizer preview iframe to prevent top-navigation
| Reported by: | westonruter | Owned by: | pento |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.1 |
| Component: | Customize | Version: | 3.4 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
We go through some hoops to prevent a script in the Customizer preview from attempting to set the top window. For example: https://github.com/WordPress/wordpress-develop/blob/2ddcc54/src/wp-includes/js/customize-preview.js#L381-L384
The iframe element in HTML5 supports a sandbox attribute which we can use to prevent the window from changing the loaded top window.
See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#attr-sandbox
Attachments (1)
Change History (4)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Hi, added the sandbox attribute excluding the top navigation token.
Removed the previous hack for preventing links from breaking out of the preview