WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 7 months ago

#42366 closed enhancement (fixed)

Missing global parameter in function comment

Reported by: janak007 Owned by: SergeyBiryukov
Milestone: 5.8 Priority: normal
Severity: minor Version: 4.9
Component: Toolbar Keywords: has-patch
Focuses: docs Cc:

Description

Hello,

There is 3rd global parameter missing in function inline comment wp_admin_bar_edit_menu() in admin-bar.php

https://ibb.co/bVpao6

Attachments (4)

before.png​ (11.8 KB) - added by janak007 4 years ago.
42366.patch​ (367 bytes) - added by janak007 4 years ago.
Added missing comment for global parameter
42366.diff​ (372 bytes) - added by munyagu 4 years ago.
Fix Format
42366.2.diff​ (448 bytes) - added by sabernhardt 7 months ago.
adding a since tag

Download all attachments as: .zip

Change History (10)

@janak007
4 years ago

@janak007
4 years ago

Added missing comment for global parameter

#1 @janak007
4 years ago

  • Keywords has-patch added
  • Resolution set to invalid
  • Status changed from new to closed

#2 @janak007
4 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#4 @rinkuyadav999
4 years ago

  • Component changed from Administration to Toolbar
  • Severity changed from normal to minor
  • Type changed from defect (bug) to enhancement

@munyagu
4 years ago

Fix Format

@sabernhardt
7 months ago

adding a since tag

#5 @sabernhardt
7 months ago

  • Milestone changed from Awaiting Review to 5.8

Thanks for the patches! The $user_id global variable explanation was added already in [44586].

However, the same function could have another @since note after [47903].

Last edited 7 months ago by sabernhardt (previous) (diff)

#6 @SergeyBiryukov
7 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from reopened to closed

In 50504:

Docs: Add a @since note to wp_admin_bar_edit_menu() about the "View Post" link on Comments screen for a single post.

Follow-up to [47903].

Props sabernhardt, janak007, munyagu.
Fixes #42366.

Note: See TracTickets for help on using tickets.