Widgets: Allow gallery widget to display images from currently-queried singular post if no images selected

[westonruter]

In #42548 (pending) a [gallery] placed inside of a Text widget will result in the attachments for a given post to be used in the gallery when the widget appears on a singular template. The same behavior could be allowed for the Gallery widget as well. If you add a gallery widget to a sidebar but don't add any images to it, the widget could conditionally show if it is being rendered on a singular template for a post that has image attachments.

[westonruter]

There may need to be a way to clear a gallery of its selected images. Currently once you select an image, you cannot reset the gallery to be empty without deleting the gallery widget and adding one in its place.

[audrasjb]

Let's address this feature in 5.2

[desrosj]

Going to punt this since 5.2 beta 1 is in less than 2 days. @audrasjb if you are able to get this ready by beta, feel free to move it back.

[audrasjb]

The timeframe is too short to have testing on this on, so I'm inclined to punt the ticket to 5.3.

[audrasjb]

Needs refresh and coding standards changes.

[audrasjb]

Patch refreshed

[audrasjb]

Tested and works fine

[audrasjb]

Hi there,

I refreshed the initial patch and I fixed some coding standards issues.
42549.1.diff looks good to go on my side (see screenshot above). On singular posts that have attached media images, the widget fallback displays those images. On any other pages (archives, posts without attached images, etc.) the widget is not displayed.

Cheers,
Jb

[desrosj]

@audrasjb Thanks for working on this one!

The patch itself looks good. It wouldn't hurt to get some unit tests, though.

Also, the concern stated in ticket:42549#comment:1 still exists. Wondering if there should be a clear button there to make this easier.

[desrosj]

With 5.3 beta 1 in a few hours, I'm going to punt this one.

[audrasjb]

Punting to Future release as we don't have time to handle this in the next few days.