Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#42623 closed defect (bug) (worksforme)

#wp-admin-bar-wp-logo incorrect styling on max-wdith: 782px.

Reported by: mressex's profile mressex Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9
Component: Toolbar Keywords: has-screenshots
Focuses: ui Cc:

Description

When resizing the browser to 782px - 601px, I've noticed the WordPress logo within the admin bar is off-centered by a few pixels.

wp-includes/css/admin-bar.css
line 872

	#wpadminbar #wp-admin-bar-wp-logo > .ab-item .ab-icon:before {
		font: 28px/1 dashicons !important;
		top: -3px;
	}

Changing top: -3px to 9px fixes this.

Tested in Chrome, Firefox and Edge.

Attachments (2)

download.png (9.7 KB) - added by mressex 8 years ago.
Admin bar with top: -3px
download1.png (9.8 KB) - added by mressex 8 years ago.
Admin bar with top: 9px

Download all attachments as: .zip

Change History (5)

@mressex
8 years ago

Admin bar with top: -3px

@mressex
8 years ago

Admin bar with top: 9px

#1 @Iceable
8 years ago

  • Keywords has-screenshots added

Hi @mressex , welcome to Trac and thank you for your bug report!

I tried to reproduce the issue but unfortunately to no avail: the icon is positioned correctly on my end for all screen sizes. I tested it in Chrome/Chromium and Firefox/Iceweasel with both 4.9 and trunk; on a clean install with Twenty Seventeen active and no plugin.

Your suggested change (top: 9px) actually pushes the logo below its expected position for me.

From your screenshot I see you are not using one of the bundled default themes. What theme are you using? Could something in this theme affect this? Do you have any plugin active? Can you still reproduce this issue with one of the default themes and no plugin?

#2 @mressex
8 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

Hey @Iceable,

I noticed this while creating a theme, the theme is completely empty (except for a few files index.php style.css). No other bundled css other than an empty style.css (Even missing the meta)

And this is where I found the error was due to my own stupidity.

After adding wp_head() to the index.php (wasn't using a header.php file just yet) the icon would be off centered (refer to screenshots) but after adding the header.php file and cutting out the <head><head/> section the error seemed to subside.

#3 @netweb
8 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.