WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Last modified 4 months ago

#42645 assigned enhancement

Support passing version number to add_editor_style()

Reported by: danielbachhuber's profile danielbachhuber Owned by: dinhtungdu's profile dinhtungdu
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch 2nd-opinion needs-refresh
Focuses: Cc:

Description

For automagically flushing browser cache, it would be helpful if add_editor_style() supported a version number argument.

Attachments (9)

42645.diff​ (1.2 KB) - added by danieltj 8 years ago.
Add a version parameter which falls back to wp version
42645.1.patch​ (1.3 KB) - added by aytac 8 years ago.
42645.2.patch​ (1.4 KB) - added by aytac 8 years ago.
The fallback check was not properly set.
42645.3.diff​ (1.4 KB) - added by danieltj 7 years ago.
Refreshed the patch and fixed CS issues.
42645.2.diff​ (1.4 KB) - added by dinhtungdu 6 years ago.
42645.4.diff​ (2.7 KB) - added by dinhtungdu 6 years ago.
42645.5.diff​ (2.2 KB) - added by dinhtungdu 6 years ago.
42645.6.diff​ (6.1 KB) - added by dinhtungdu 6 years ago.
42645.7.diff​ (6.3 KB) - added by dinhtungdu 6 years ago.

Download all attachments as: .zip

Change History (25)

This ticket was mentioned in ​Slack in #core by jeffpaul. ​View the logs.
8 years ago

@danieltj
8 years ago

Add a version parameter which falls back to wp version

#2 @danieltj
8 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Added 42645.diff​ which includes a new parameter to accept a version number in the array which defaults to the WP version number.

#3 @SergeyBiryukov
8 years ago

  • Milestone changed from Future Release to 5.0

#4 @aytac
8 years ago

Diff needed refreshed

@aytac
8 years ago

@aytac
8 years ago

The fallback check was not properly set.

@danieltj
7 years ago

Refreshed the patch and fixed CS issues.

This ticket was mentioned in ​Slack in #core by danieltj. ​View the logs.
7 years ago

#6 @pento
7 years ago

  • Milestone changed from 5.0 to 5.1

#7 @pento
7 years ago

  • Milestone changed from 5.1 to 5.2

#8 @desrosj
7 years ago

  • Milestone changed from 5.2 to 5.3

This still needs testing and feedback.

This ticket was mentioned in ​Slack in #core-editor by benoitchantre. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
6 years ago

#11 @davidbaumwald
6 years ago

  • Keywords needs-refresh added
  • Owner set to dinhtungdu
  • Status changed from new to assigned

@dinhtungdu
6 years ago

@dinhtungdu
6 years ago

@dinhtungdu
6 years ago

#12 @dinhtungdu
6 years ago

Current working patch: attachment:42645.5.diff​ is just a proof of concept. I'm not satisfied with the code and working on a better implementation.

#13 @desrosj
6 years ago

  • Milestone changed from 5.3 to Future Release

This one still needs more work. I am going to punt this since 5.3 beta 1 is in less than 3 days.

@dinhtungdu
6 years ago

#14 @dinhtungdu
6 years ago

  • Keywords needs-refresh removed

@desrosj Should we change this ticket back to 5.3 with 42645.6.diff​.

Last edited 6 years ago by dinhtungdu (previous) (diff)

@dinhtungdu
6 years ago

#15 @desrosj
6 years ago

Unfortunately, the deadline for enhancement and feature requests being committed for 5.3 has passed with the Beta 1 release yesterday. But, as soon as trunk is opened for 5.4 commits, this can be considered!

#16 @SirLouen
4 months ago

  • Keywords 2nd-opinion needs-refresh added; needs-testing removed

@dinhtungdu it seems this has been rolling around for a long.

Again, unfortunately this patch is not applying. Needs some refresh, specially for edit-form-blocks.php that has changed significantly.

Wondering if this is still worthy given the decline of TinyMCE.

We are not in 2017 any more, when this was opened, so, at this point, I would say this require a 2nd-opinion

Note: See TracTickets for help on using tickets.