Default selected changeset status should not be publish when current user does not have publish capability

[sayedwp]

The default state of wp.customize.state( 'selectedChangesetStatus' ) is set to publish even when the user does not have the publish capability. And its value is changed to draft if wp.customize.settings.changeset.currentUserCanPublish is false and the state changes.

This would work fine if there is no extra status added by a plugin. However if a plugin tries to add status like pending and user clicks on it, it would create issues because the selectedChangesetStatus is forced to stay draft. See issue ​https://github.com/xwp/wp-customize-snapshots/issues/167

[dd32]

Bumping to 4.9.3 due to 4.9.2s release

[westonruter]

@sayedwp one tweak I have for the patch:

src/wp-admin/js/customize-controls.js

@@ -7938 +7938 @@
                                                 } else {
                                                         saveBtn.val( api.l10n.schedule );
                                                 }
-                                        } else {
+                                        } else if ( api.settings.changeset.currentUserCanPublish ) {
                                                 saveBtn.val( api.l10n.publish );
                                         }
                                         closeBtn.find( '.screen-reader-text' ).text( api.l10n.cancel );

It doesn't seem to change the end result, at least with Customize Snapshots active, but it would seem that we should only be setting the saveBtn's label to publish if the user can indeed publish.

[westonruter]

In 42543:

Customize: Let default status for Customizer be draft if user does not have capability to publish.

Amends [41626].
Props sayedwp, westonruter.
See #30937.
Fixes #42686.

[westonruter]

In 42544:

Customize: Let default status for Customizer be draft if user does not have capability to publish.

Amends [41626].
Props sayedwp, westonruter.
See #30937.
Fixes #42686 for 4.9 branch.