WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 19 months ago

Last modified 9 months ago

#42784 closed defect (bug) (fixed)

is_day() needs an inline doc description

Reported by: webdevmattcrom Owned by: jorbin
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: General Keywords:
Focuses: docs Cc:

Description

The name of this function and the title in the inline docs does not adequately describe the purpose of this function. Additionally, adding a description is useful/beneficial for DevHub.

Suggested Description:
"A conditional check to test whether the page is a date-based archive page."

Attachments (2)

ticket#42784.patch (387 bytes) - added by webdevmattcrom 19 months ago.
Patch for ticket #42784 -- adds inline description per suggestion.
ticket#42784-b.patch (423 bytes) - added by webdevmattcrom 19 months ago.
Amended patch for ticket #42784

Download all attachments as: .zip

Change History (7)

@webdevmattcrom
19 months ago

Patch for ticket #42784 -- adds inline description per suggestion.

#1 @webdevmattcrom
19 months ago

Apologies, ignore the patch above. The description should be:
"A conditional check to test whether the page is a date-based archive page for the current day."

New patch being uploaded soon.

@webdevmattcrom
19 months ago

Amended patch for ticket #42784

#2 @jorbin
19 months ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 42355:

Docs: Add description for is_day().

Props webdevmattcrom.
Fixes #42784.

#3 @netweb
19 months ago

  • Milestone changed from Awaiting Review to 5.0

#4 @webdevmattcrom
19 months ago

Thanks @jorbin Since that's my first patch to be accepted ever, you'll always have a special place in my heart now :-)

#5 @johnbillion
9 months ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.