Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#42784 closed defect (bug) (fixed)

is_day() needs an inline doc description

Reported by: webdevmattcrom Owned by: jorbin
Priority: normal Milestone: 5.1
Component: General Version: 5.1
Severity: normal Keywords:
Cc: Focuses: docs

Description

The name of this function and the title in the inline docs does not adequately describe the purpose of this function. Additionally, adding a description is useful/beneficial for DevHub.

Suggested Description:
"A conditional check to test whether the page is a date-based archive page."

Attachments (2)

ticket#42784.patch​ (387 bytes ) - added by webdevmattcrom 9 years ago.
Patch for ticket #42784 -- adds inline description per suggestion.
ticket#42784-b.patch​ (423 bytes ) - added by webdevmattcrom 9 years ago.
Amended patch for ticket #42784

Download all attachments as: .zip

Change History (7)

@webdevmattcrom
9 years ago

Patch for ticket #42784 -- adds inline description per suggestion.

#1 @webdevmattcrom
9 years ago

Apologies, ignore the patch above. The description should be:
"A conditional check to test whether the page is a date-based archive page for the current day."

New patch being uploaded soon.

@webdevmattcrom
9 years ago

Amended patch for ticket #42784

#2 @jorbin
9 years ago

  • Owner set to jorbin
  • Resolution → fixed
  • Status new → closed

In 42355:

Docs: Add description for is_day().

Props webdevmattcrom.
Fixes #42784.

#3 @netweb
9 years ago

  • Milestone Awaiting Review → 5.0

#4 @webdevmattcrom
9 years ago

Thanks @jorbin Since that's my first patch to be accepted ever, you'll always have a special place in my heart now :-)

#5 @johnbillion
8 years ago

  • Milestone 5.0 → 5.1
Note: See TracTickets for help on using tickets.