WordPress.org

Make WordPress Core

Opened 7 months ago

Last modified 5 months ago

#42811 new defect (bug)

Run the PHP 5.2 Travis job with the MySQL Extension

Reported by: dd32 Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description (last modified by dd32)

I just noticed that the PHP 5.2 job is running with MySQLi (which I didn't even realise was possible).

That ultimately means we have no automated testing which is testing the mysql_* functions in $wpdb which is used for PHP 5.2~5.4 by default.

The attached patch uses WP_USE_EXT_MYSQL to force it to use the MySQL extension for the PHP 5.2 job, I've tested this on my own travis account and it passes as expected, with the only change being an additional skipped test (which requires mysqli).

Attachments (1)

42811.diff (1.5 KB) - added by dd32 7 months ago.

Download all attachments as: .zip

Change History (5)

@dd32
7 months ago

#2 @pento
7 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.0

What an exciting time to be alive!

#3 @dd32
7 months ago

  • Description modified (diff)

Just noticed I incorrectly referenced mysqli_* functions instead of mysql_* functions :)

#4 @dd32
5 months ago

I got to thinking - now that PHP 5.2 could legitimately be running MySQLi in production, we probably shouldn't take the route in 42811.diff directly.

Maybe this means we need another job dedicated to MySQL - although it doesn't need to be PHP 5.2, perhaps it could be a 5.6 job? If we were to limit PHP 5.2 jobs to MySQL-only we'd miss out on the regular testing of the least-feature-complete version of MySQLi out there.

Note: See TracTickets for help on using tickets.