Opened 7 years ago
Closed 4 years ago
#42811 closed defect (bug) (wontfix)
Run a Travis job with the MySQL Extension
Reported by: | dd32 | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch needs-refresh |
Focuses: | Cc: |
Description (last modified by )
I just noticed that the PHP 5.2 job is running with MySQLi (which I didn't even realise was possible).
That ultimately means we have no automated testing which is testing the mysql_*
functions in $wpdb
which is used for PHP 5.2~5.4 by default.
The attached patch uses WP_USE_EXT_MYSQL
to force it to use the MySQL extension for the PHP 5.2 job, I've tested this on my own travis account and it passes as expected, with the only change being an additional skipped test (which requires mysqli).
Attachments (1)
Change History (12)
#2
@
7 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 5.0
What an exciting time to be alive!
#3
@
7 years ago
- Description modified (diff)
Just noticed I incorrectly referenced mysqli_*
functions instead of mysql_*
functions :)
#4
@
7 years ago
I got to thinking - now that PHP 5.2 could legitimately be running MySQLi in production, we probably shouldn't take the route in 42811.diff directly.
Maybe this means we need another job dedicated to MySQL - although it doesn't need to be PHP 5.2, perhaps it could be a 5.6 job?
If we were to limit PHP 5.2 jobs to MySQL-only we'd miss out on the regular testing of the least-feature-complete version of MySQLi out there.
#6
@
6 years ago
- Keywords needs-refresh added; commit removed
- Milestone changed from 5.1 to 5.2
With WordPress' PHP version bump coming up, let's just add an extra PHP 5.6 job that tests with ext/mysql
.
#7
@
6 years ago
- Milestone changed from 5.2 to 5.3
Bumping this from 5.2 due to lack of progress but as it is related to a test config and not something that directly affects the code we release, I'm happy to bring it back if there is progress.
#8
@
6 years ago
- Summary changed from Run the PHP 5.2 Travis job with the MySQL Extension to Run a Travis job with the MySQL Extension
#9
@
5 years ago
- Milestone changed from 5.3 to Future Release
Having this for PHP 5.6 is no longer an issue, the 42811.diff does need a refresh to match up with the new Docker'ised changes to Travis CI setup.
For now, punting this back to 'future release', feel free to move this back into the current milestone once the patch has been refreshed.
I've created a pull request to test 42811.diff https://github.com/WordPress/wordpress-develop/pull/9