WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#42837 closed defect (bug) (fixed)

wp_normalize_path does not take into account stream wrappers

Reported by: calin's profile calin Owned by: dd32's profile dd32
Milestone: 4.9.7 Priority: normal
Severity: normal Version: 3.9
Component: Filesystem API Keywords:
Focuses: Cc:

Description

wp_normalize_path does not take into account stream paths using php stream wrappers. I've attached a patch to fix this.

Attachments (2)

wp_normalize_path.diff​ (632 bytes) - added by calin 6 years ago.
wp_normalize_path_tests.diff​ (580 bytes) - added by calin 6 years ago.

Download all attachments as: .zip

Change History (11)

@calin
6 years ago

#1 @swissspidy
6 years ago

  • Component changed from General to Filesystem API
  • Keywords has-patch added
  • Version changed from trunk to 3.9

#2 @dd32
6 years ago

  • Keywords needs-unit-tests added

This would be a good candidate for some unit tests covering the current and new behaviour here.

#3 @calin
6 years ago

@dd32 I've attached a patch for tests.

@calin
6 years ago

#4 @dd32
6 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 42387:

Filesystem: Allow wp_normalise_path() to handle PHP stream wrappers such as php:// correctly.

Props calin, dd32.
Fixes #42837.

#5 @dd32
6 years ago

  • Milestone changed from Awaiting Review to 5.0

#6 @johnbillion
6 years ago

In 43406:

Media: Update the @since tag for wp_normalize_path() as this has been backported to th 3.9 (and all other) branches.

See #42837

This ticket was mentioned in ​Slack in #core-media by otto42. ​View the logs.
6 years ago

#8 @johnbillion
6 years ago

  • Keywords has-patch needs-unit-tests removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

[42387] and [43406] should be merged into 5.0

#9 @pento
6 years ago

  • Milestone changed from 5.0 to 4.9.7
  • Resolution set to fixed
  • Status changed from reopened to closed

They were both merged into the 4.9 branch in [43393], so already exist in the 5.0 branch.

Last edited 6 years ago by pento (previous) (diff)
Note: See TracTickets for help on using tickets.