WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#42906 closed enhancement (invalid)

Please bring back the image caption visibility in TinyMCE visual editor

Reported by: eliz82 Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9.1
Component: TinyMCE Keywords:
Focuses: ui Cc:

Description

On Wordpress 3.4.2 the visibility of images with caption in TinyMCE visual editor is very good.

In Wordpress 3.9.x and 4.x images caption is hardly visible:
--The image caption is aligned to the left and on a white background.This is exactly like a normal text between the images. It's harder to distinguish caption text from the post text.
--There is no space (css margin) between consecutive images

this was default style for caption in Wordpress 3.4.2

.wp-caption {
    background-color: #f3f3f3;
    border: 1px solid #ddd;
    text-align: center;
    margin: 10px 0;
}

That was fine, caption text is at the middle of the image on a grey background, the images are clearly delimited with a border and there is space between consecutive images. Please add this style to the recent versions.

P.S. sorry for not selecting the version properly in the ticket but your select version is missing the latest 3.9.x versions.

Attachments (2)

2017-12-14_WP3.4.2.jpg (74.0 KB) - added by eliz82 3 years ago.
wordpress 3.4.2
2017-12-14_WP3.9.22.jpg (101.8 KB) - added by eliz82 3 years ago.
wordpress 3.9.22

Download all attachments as: .zip

Change History (5)

@eliz82
3 years ago

wordpress 3.4.2

@eliz82
3 years ago

wordpress 3.9.22

#1 @eliz82
3 years ago

  • Resolution set to invalid
  • Status changed from new to closed

I digged more

"wp-includes\js\tinymce\skins\wordpress\wp-content.css" (wp 3.9.22) contain this

.wp-caption {
	border: 1px solid #ddd;
	text-align: center;
	background-color: #f3f3f3;
	padding-top: 4px;
	margin: 10px 0;
}

but also contain this under:

.html5-captions .wp-caption {
	border: none;
	background-color: transparent;
	margin: 0;
	padding: 0;
}

so probably later will overwrite the first.

I also detected some ".wp-caption" in the default wordpress themes. But i don't think themes CSS is executed in the TinyMCE editor.

#2 @eliz82
3 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

closed ticket by mistake
"invalid" seem to autoselect when adding a comment to my ticked ... damn

#3 @azaozz
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from reopened to closed

Hi @eliz82,

But i don't think themes CSS is executed in the TinyMCE editor.

It is. There is a separate file usually named editor-style.css that is loaded in the editor so themes can add their own styles. Themes can also select if they want to use the html5-captions which not only changes the styles but also the width of the caption wrapper element.

Re-closing as invalid, feel free to reopen if you think we should change the default styling (although you probably won't see it as most themes add their own captions styles).

Note: See TracTickets for help on using tickets.