WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 days ago

#42929 closed enhancement (fixed)

Indicate when a media file is selected as the video header

Reported by: desrosj Owned by: desrosj
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch has-screenshots commit
Focuses: ui, administration Cc:

Description

When a theme supports video headers and a video is chosen, it is not indicated as the current header media in the media library.

Site logos, favicons, and header images are already marked in the media library.

Attachments (4)

current-indicators.png (227.0 KB) - added by desrosj 3 years ago.
Logo, header image, and site icon indicators.
Screenshot 2020-08-31 at 12.33.10.png (173.2 KB) - added by Mista-Flo 7 weeks ago.
Screenshot with the applied patch
42929.1.patch (645 bytes) - added by Mista-Flo 7 weeks ago.
Screen Shot 2020-10-15 at 6.00.41 PM.png (29.4 KB) - added by garrett-eclipse 6 days ago.
Successful Test

Download all attachments as: .zip

Change History (20)

@desrosj
3 years ago

Logo, header image, and site icon indicators.

#1 @desrosj
3 years ago

  • Focuses administration added
  • Type changed from defect (bug) to enhancement

#2 @desrosj
3 years ago

  • Focuses ui added

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


20 months ago

#4 @antpb
20 months ago

  • Milestone changed from Awaiting Review to Future Release

#5 @mikeschroder
20 months ago

Just a quick comment to mention that I agree that this would be a great enhancement.

#6 @desrosj
20 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

@Mista-Flo
7 weeks ago

Screenshot with the applied patch

@Mista-Flo
7 weeks ago

#7 @Mista-Flo
7 weeks ago

  • Keywords has-patch has-screenshots added; needs-patch removed

Hi there, I have uploaded a patch to fix this inconsistency, I tried to keep the code as clean as possible, tell me if it's okay :)

This ticket was mentioned in Slack in #core-media by florian-tiar. View the logs.


7 weeks ago

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


6 weeks ago

This ticket was mentioned in Slack in #core-media by florian-tiar. View the logs.


13 days ago

#11 @antpb
13 days ago

  • Keywords needs-testing added
  • Milestone changed from Future Release to 5.6

This is a very nice candidate for 5.6 and looks like a solid fix. Moving into milestone.

This ticket was mentioned in Slack in #core by francina. View the logs.


12 days ago

#13 @antpb
7 days ago

This is still on my radar and will be committed before Beta 1. (just want to make sure tests are good, etc)

This ticket was mentioned in Slack in #core-media by garrett-eclipse. View the logs.


6 days ago

#15 @garrett-eclipse
6 days ago

  • Keywords commit added; needs-testing removed

This applies cleanly and tests well both manually and automated tests. Moving forward.

#16 @antpb
2 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 49205:

Media: Indicate if media is header video in media library.
This introduces a label to indicate if a piece of media is being used as a video header in the media library.
Props desrosj, Mista-Flo, mikeschroder.
Fixes #42929.

Note: See TracTickets for help on using tickets.