Customizer: Search Menu item not working on Custom Link

[monikarao]

In Customizer "Search Menu Item Field" is present to search all menu items but it's not working on Custom Links.
Ex. Added "Home" as Custom Link but when searching this "Home" it displayed message "no-result-found".

[monikarao]

Created Home Custom Link

[monikarao]

On Searching "Home" - No Result Found Message

[melchoyce]

Good catch!

[monikarao]

Thanks @melchoyce

[audrasjb]

Add home custom link in customizer menu search

[audrasjb]

Hi @monikarao @melchoyce

I made a patch for this ticket. It works well.
Here is a screenshot of the result.

Cheers,
Jb

[audrasjb]

Result

[dd32]

Bumping to 4.9.3 due to 4.9.2s release

[Clorith]

Thanks for the patch, looking over it I notice it's currently appending the Home menu item to any search.

It will need an if statement there to make sure the translatable Home label matches before being appended

[audrasjb]

add if statement before Home item appending

[audrasjb]

Test: not appending on "Test" search but in "Hom" string yes :)

[audrasjb]

Thanks @Clorith for the review, you're right !

In 42991.2.diff I added a condition to check if the entered string matches with Home (translatable).

[westonruter]

@audrasjb tip: you can use stripos() instead of strpos() with multiple strtolower() calls.

[westonruter]

On second thought, this perhaps should use mb_stripos() if possible since the translation string will have multi-byte characters in it. For example compare:

wp> stripos( 'PAPÁ', 'á' )
=> bool(false)
wp> mb_stripos( 'PAPÁ', 'á' )
=> int(3)

I believe you'll have to check if the mb_stripos() function exists since the multibyte string functions may not be present, and in such case you'll need to use stripos(). At least, _wp_json_convert_string() checks for the existence of an mb_* function prior to using it.

[audrasjb]

Thanks @westonruter for your help, this is very interesting I'm really happy to learn things at the same time I contribute :)

So, here is a new tested patch which seems to work fine. Is this better?

[audrasjb]

Add mb_stripos/stripos function and Yoda styled conditions

[audrasjb]

Remove extra spaces L. 391 & 402

[westonruter]

@audrasjb I suggest removing some of the duplication, following something like this:

<?php
if ( isset( $args['s'] ) ) {
        $title = _x( 'Home', 'nav menu home label' );
        $matches = function_exists( 'mb_stripos' ) ? false !== mb_stripos( $title, $args['s'] ) : false !== stripos( $title, $args['s'] );
        if ( $matches ) {
                $items[] = array(
                        // ...
                        'title'      => $title,
                        // ...
                );
        }
}

[audrasjb]

Thanks @westonruter for the suggestion and for this hint. I was wondering if I had to duplicate or not…
Let's roll!
Will send a new version soon.

[audrasjb]

Here is a new patch without code duplication

[westonruter]

@melchoyce does 42991.5.diff​ work as you expect?

[melchoyce]

Looks good to me!

[westonruter]

In 42611:

Customize: Include nav menu item for Home custom link in search results for "Home".

Props audrasjb, westonruter.
Fixes #42991.

[SergeyBiryukov]

In 42621:

Customize: Include nav menu item for Home custom link in search results for "Home".

Props audrasjb, westonruter.
Merges [42611] to the 4.9 branch.
Fixes #42991.

[monikarao]

Hello @SergeyBiryukov

I didn't get props on this ticket.

[SergeyBiryukov]

Hi @monikarao,

In the past only the patch author would generally get the props, however recently we've indeed ​started to give props for other contributions as well, including bug reports. I'll make sure to include you in the contributors list for 4.9.3. Thanks for the ticket!

[monikarao]

Thanks @SergeyBiryukov