WordPress.org

Make WordPress Core

#43016 closed defect (bug) (fixed)

Update review filter links in Admin Dashboard (plugins modal window)

Reported by: Darko A7 Owned by: afercia
Milestone: 4.9.3 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch fixed-major
Focuses: Cc:
PR Number:

Description

Hi,

  1. Open a plugin modal window inside WordPress's Admin Dashboard (e.g. through "Add new" plugin > More details or from the list of already installed/available plugins)
  1. Scroll to reviews section (on the right, below), then click on e.g. 1 star reviews hyperlink, we are redirected to the general review page (e.g. all stars) instead of selected (1 star).

Currently (as of latest 4.9.1) the admin dashboard link is in the form:

https: wordpress.org /support/view/plugin-reviews/product-name?filter=1

And the link on the main wordpress.org website is in the form:

https: wordpress.org /support/plugin/product-name/reviews/?filter=1

This change clearly caused the issue, as the links were changed at some point, but the update is not covered in the modal (popup) section.

Thanks!
Regards

Attachments (1)

43016.diff (1.2 KB) - added by afercia 22 months ago.

Download all attachments as: .zip

Change History (8)

@afercia
22 months ago

#1 @afercia
22 months ago

  • Component changed from Permalinks to Plugins
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.9.2
  • Owner set to afercia
  • Status changed from new to accepted
  • Version 4.9.1 deleted

Thanks @Darko A7 good catch! 43016.diff updates the link and also removes a trailing space. I'd say it's simple enough for 4.9.2 consideration.

#2 follow-up: @johnbillion
22 months ago

Ideally this would be handled as a redirect on w.org.

#3 in reply to: ↑ 2 @SergeyBiryukov
21 months ago

Replying to johnbillion:

Ideally this would be handled as a redirect on w.org.

There is a redirect, but it does not respect the filter parameter. Created #meta3379 for that.

The links should be updated anyway.

Last edited 21 months ago by SergeyBiryukov (previous) (diff)

#4 @SergeyBiryukov
21 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 42459:

Plugins: Update review filter links in Details modal.

Props darko-a7, afercia.
Fixes #43016. See #meta3379.

#5 @SergeyBiryukov
21 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#6 @dd32
21 months ago

  • Milestone changed from 4.9.2 to 4.9.3

Bumping to 4.9.3 due to 4.9.2s release

#7 @SergeyBiryukov
21 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42524:

Plugins: Update review filter links in Details modal.

Props darko-a7, afercia.
Merges [42459] to the 4.9 branch.
Fixes #43016. See #meta3379.

Note: See TracTickets for help on using tickets.