WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#43020 closed defect (bug) (fixed)

Improve JS Documentation: customize-image-cropper.js

Reported by: ireneyoast's profile ireneyoast Owned by: atimmer's profile atimmer
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Media Keywords: has-patch
Focuses: javascript, docs Cc:

Description

In our ongoing effort to improve JavaScript documentation, this patch adds descriptions and JSDoc formatting to the following file:

customize-image-cropper.js

Please give props to:

Attachments (2)

customize-image-cropper.diff​ (1.5 KB) - added by ireneyoast 6 years ago.
customize-image-cropper-2.diff​ (1.5 KB) - added by ireneyoast 6 years ago.

Download all attachments as: .zip

Change History (10)

@ireneyoast
6 years ago

@ireneyoast
6 years ago

#1 @ireneyoast
6 years ago

We've submitted a revised patch in which we've removed two unnecessary @augments.

#2 @netweb
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.0
  • Owner set to atimmer
  • Status changed from new to assigned

#3 @atimmer
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42435:

Docs: Improve JS Docs for controllers/customize-image-cropper.js.

Props manuelaugustin, bramheijmink, andizer, ireneyoast.
Fixes #43020.

#4 @johnbillion
5 years ago

  • Milestone changed from 5.0 to 5.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @pento
5 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @pento
5 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#7 @audrasjb
5 years ago

  • Milestone changed from 5.0.3 to 5.1

Hi,

Per today's bug scrub, we are going to address Docs enhancements in 5.1, coming next month.

#8 @atimmer
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

As this has landed in trunk and 5.1 will release everything in trunk, I'll close this.

Note: See TracTickets for help on using tickets.