WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 21 months ago

Last modified 13 months ago

#43072 closed defect (bug) (fixed)

Explain what type of editor it is in Appearance

Reported by: karmatosed Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: ux-feedback has-patch
Focuses: ui Cc:
PR Number:

Description

Right now editor appears in the menu:

https://cldup.com/4eQShChbDC.png

This is a little odd and likely gets new users. Sure those of us that use it all the time get that it's the code editor, but you would have to know that.

What about changing it to 'code editor' or just something that provides more insight?

Attachments (1)

43072.diff (2.9 KB) - added by xkon 21 months ago.
Theme Editor / Plugin Editor

Download all attachments as: .zip

Change History (14)

#1 @karmatosed
22 months ago

  • Keywords ux-feedback added

#2 @karmatosed
22 months ago

  • Focuses ui added

#3 follow-up: @SergeyBiryukov
22 months ago

  • Milestone changed from Awaiting Review to 5.0

There's also an Editor item under Plugins.

I'd suggest renaming the one under Appearance to "Theme Editor" and the one under Plugins to "Plugin Editor".

#4 in reply to: ↑ 3 @melchoyce
22 months ago

Replying to SergeyBiryukov:

I'd suggest renaming the one under Appearance to "Theme Editor" and the one under Plugins to "Plugin Editor".

+1

Edit: Or rename both to Code Editor.

Last edited 22 months ago by melchoyce (previous) (diff)

#5 @sasiddiqui
22 months ago

I'd suggest renaming the one under Appearance to "Theme Editor" and the one under Plugins to "Plugin Editor".

+1

@xkon
21 months ago

Theme Editor / Plugin Editor

#6 @xkon
21 months ago

  • Keywords has-patch added

Since I was making some things around the Editor in general I thought of making this ( 43072.diff ) as well just in case it comes easier for someone to apply it and see how @SergeyBiryukov suggestion feels. It makes way more sense to have them named this way.

#7 @SergeyBiryukov
21 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42685:

Administration: Rename Appearance → Editor menu item to Theme Editor and Plugins → Editor to Plugin Editor for clarity.

Props xkon, karmatosed.
Fixes #43072.

#8 follow-up: @ocean90
21 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

There is no need to capitalize "plugin editor" in the help text, is there?

#9 in reply to: ↑ 8 @SergeyBiryukov
21 months ago

Replying to ocean90:

There is no need to capitalize "plugin editor" in the help text, is there?

Just made it consistent with theme editor help text:
https://core.trac.wordpress.org/browser/tags/4.9/src/wp-admin/theme-editor.php?marks=27#L23

#10 @SergeyBiryukov
21 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

The initial issue is fixed, feel free to open a new ticket if the help text needs some further adjustments.

#11 @ocean90
21 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm going to fix this.

#12 @ocean90
21 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42757:

Administration: Remove unnecessary capitalization when referencing to plugin/theme editors.

Fixes #43072.

#13 @pento
13 months ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.