WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Last modified 7 years ago

#43076 assigned defect (bug)

current-menu-item for archive menu item on singular page

Reported by: sebastian.pisula Owned by: audrasjb
Priority: normal Milestone: Future Release
Component: Menus Version:
Severity: normal Keywords: has-patch reporter-feedback needs-refresh
Cc: Focuses:

Description

If I have CPT with archive and singular page and I add to menu url to archive and I go to singular page of CPT then should be add current-menu-item to menu item of archive

Attachments (1)

43076.patch​ (782 bytes ) - added by sebastian.pisula 9 years ago.

Download all attachments as: .zip

Change History (5)

@sebastian.pisula
9 years ago

#1 @sebastian.pisula
9 years ago

  • Keywords has-patch added

#2 @audrasjb
8 years ago

  • Keywords reporter-feedback added
  • Owner set to audrasjb
  • Status new → reviewing

Hi and thanks for the ticket and you patch,

I think the patch will need some refresh and some correction to fit better with WPCS. However, I'm not sure it's 100% relevant to add current-menu-item class to archive page when we are in a singular Post: the Post may belong to different taxonomy terms and also, the singular Post itself may appear in the menu items.

Last edited 8 years ago by audrasjb (previous) (diff)

#3 @audrasjb
7 years ago

  • Keywords needs-refresh added
  • Milestone Awaiting Review → 5.4
  • Status reviewing → accepted

#4 @audrasjb
7 years ago

  • Milestone 5.4 → Future Release
  • Status accepted → assigned

Moving to future release and adding reporter feedback keyword (see comment 2).

Note: See TracTickets for help on using tickets.