WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Last modified 5 years ago

#43076 assigned defect (bug)

current-menu-item for archive menu item on singular page

Reported by: sebastianpisula's profile sebastian.pisula Owned by: audrasjb's profile audrasjb
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch reporter-feedback needs-refresh
Focuses: Cc:

Description

If I have CPT with archive and singular page and I add to menu url to archive and I go to singular page of CPT then should be add current-menu-item to menu item of archive

Attachments (1)

43076.patch​ (782 bytes) - added by sebastian.pisula 7 years ago.

Download all attachments as: .zip

Change History (5)

@sebastian.pisula
7 years ago

#1 @sebastian.pisula
7 years ago

  • Keywords has-patch added

#2 @audrasjb
6 years ago

  • Keywords reporter-feedback added
  • Owner set to audrasjb
  • Status changed from new to reviewing

Hi and thanks for the ticket and you patch,

I think the patch will need some refresh and some correction to fit better with WPCS. However, I'm not sure it's 100% relevant to add current-menu-item class to archive page when we are in a singular Post: the Post may belong to different taxonomy terms and also, the singular Post itself may appear in the menu items.

Last edited 6 years ago by audrasjb (previous) (diff)

#3 @audrasjb
5 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 5.4
  • Status changed from reviewing to accepted

#4 @audrasjb
5 years ago

  • Milestone changed from 5.4 to Future Release
  • Status changed from accepted to assigned

Moving to future release and adding reporter feedback keyword (see comment 2).

Note: See TracTickets for help on using tickets.