WordPress.org

Make WordPress Core

Opened 21 months ago

Last modified 9 months ago

#43076 reviewing defect (bug)

current-menu-item for archive menu item on singular page

Reported by: sebastian.pisula Owned by: audrasjb
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch reporter-feedback
Focuses: Cc:
PR Number:

Description

If I have CPT with archive and singular page and I add to menu url to archive and I go to singular page of CPT then should be add current-menu-item to menu item of archive

Attachments (1)

43076.patch (782 bytes) - added by sebastian.pisula 21 months ago.

Download all attachments as: .zip

Change History (3)

#1 @sebastian.pisula
21 months ago

  • Keywords has-patch added

#2 @audrasjb
9 months ago

  • Keywords reporter-feedback added
  • Owner set to audrasjb
  • Status changed from new to reviewing

Hi and thanks for the ticket and you patch,

I think the patch will need some refresh and some correction to fit better with WPCS. However, I'm not sure it's 100% relevant to add current-menu-item class to archive page when we are in a singular Post: the Post may belong to different taxonomy terms and also, the singular Post itself may appear in the menu items.

Last edited 9 months ago by audrasjb (previous) (diff)
Note: See TracTickets for help on using tickets.