WordPress.org

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#4309 closed defect (bug) (invalid)

Recent Comments widget does not respect trackback/pingback preference

Reported by: technosailor Owned by: technosailor
Milestone: Priority: low
Severity: normal Version: 2.2.1
Component: Administration Keywords: widgets comments
Focuses: Cc:

Description

if the default_pingback_status is set to closed, the recent comments widget does not respect that user-choice and displays trackbacks/pingbacks anyways. The attached patch checks the option value and runs a modified query that eliminates trackbacks/pingbacks from the resulting dataset.

Attachments (1)

widgets-recent-comments-respect-trackback-pref.diff (1.1 KB) - added by technosailor 15 years ago.
Replaces original that had other mods included. My bad.

Download all attachments as: .zip

Change History (6)

@technosailor
15 years ago

Replaces original that had other mods included. My bad.

#1 @Otto42
15 years ago

I don't understand the problem. If the comments are closed, but comments *exist* for it before they're closed, then you would want those to display. Closing comments/pings just prevents new ones from being added, it doesn't make existing ones disappear.

Also, your patch is checking the default ping status, not the status on individual posts. So it's going to not show pings for posts that are still actually allowing pings. The patch and problem doesn't make any sense.

#2 follow-up: @technosailor
15 years ago

I'll rework the patch as you're right - I failed to acknowledge individual posts. The problem, for clarification, is that when the default ping status is closed - as it is in my cases, pings/trackbacks are not shown on posts (unless, as you say, I've specifically opened them or older posts that had ping status open). It doesn't seem right then, in that case, to show pings/trackbacks from blogs when I haven't approved them from being posted to the blog. I'll rework the patch this evening.

#3 in reply to: ↑ 2 @Otto42
15 years ago

Replying to technosailor:

The problem, for clarification, is that when the default ping status is closed - as it is in my cases, pings/trackbacks are not shown on posts (unless, as you say, I've specifically opened them or older posts that had ping status open). It doesn't seem right then, in that case, to show pings/trackbacks from blogs when I haven't approved them from being posted to the blog. I'll rework the patch this evening.

Okay then, but I still fail to see the problem. The recent comments widget can only show pings and comments that are actually made. And for them to be made, comments/pings must be open on that specific post. In other words, the pings must exist to be shown, and the pings must be open for the pings to exist. So if it exists, then pings are open for that post, and your (proposed) patch does nothing whatsoever.

As far as approval goes, it's checking that comment_approved=1, so unapproved comments/pings still won't be shown until you approve them.

#4 @technosailor
15 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Good point. Again. Let's close this ticket then.

#5 @rob1n
15 years ago

  • Milestone 2.2.1 deleted
Note: See TracTickets for help on using tickets.