WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#43230 closed defect (bug) (fixed)

JSDoc: wp-includes/js/media/views/spinner.js

Reported by: avillegasn's profile avillegasn Owned by: atimmer's profile atimmer
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: docs, javascript Cc:

Description

Added documentation.

Attachments (2)

spinner.diff​ (1009 bytes) - added by avillegasn 5 years ago.
JS documentation added
spinner.2.diff​ (1008 bytes) - added by avillegasn 5 years ago.
Fixed JS documentation.

Download all attachments as: .zip

Change History (11)

@avillegasn
5 years ago

JS documentation added

#1 @avillegasn
5 years ago

  • Keywords has-patch added

@avillegasn
5 years ago

Fixed JS documentation.

#2 @atimmer
5 years ago

Thank you for your contribution!

As far as I could see the Spinner was introduced in this commit: ​https://github.com/WordPress/wordpress-develop/commit/15533d1d1fc6c249ac3b99be8b30234463b6ced3. The first release that was in was 3.9.0, so I changed to @since tags.

@access public is not necessary because this is the default access. I've also added a comment about the delay that's in the show method. This helps people understand the code.

#3 @atimmer
5 years ago

  • Owner set to atimmer
  • Resolution set to fixed
  • Status changed from new to closed

In 42675:

Docs: Improve JSDoc for media/views/spinner.js.

Props avillegasn.
Fixes #43230.

#4 @netweb
5 years ago

  • Focuses changed from docs javascript to docs, javascript
  • Milestone changed from Awaiting Review to 5.0

#5 @johnbillion
5 years ago

  • Milestone changed from 5.0 to 5.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

#6 @pento
4 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#7 @pento
4 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#8 @audrasjb
4 years ago

  • Milestone changed from 5.0.3 to 5.1

Hi,

Per today's bug scrub, we are going to address Docs enhancements in 5.1, coming next month.

#9 @desrosj
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

I don't think anything further is required here. It was reopened for backport considerations, but there will not be a 5.0.4.

Note: See TracTickets for help on using tickets.